Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to IPython 5.0 #21006

Closed
vbraun opened this issue Jul 11, 2016 · 33 comments
Closed

Upgrade to IPython 5.0 #21006

vbraun opened this issue Jul 11, 2016 · 33 comments

Comments

@vbraun
Copy link
Member

vbraun commented Jul 11, 2016

IPython 5.0 and various minor updates

Depends on #20923

CC: @kiwifb

Component: packages: standard

Author: Volker Braun

Branch: 701b91d

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/21006

@vbraun vbraun added this to the sage-7.3 milestone Jul 11, 2016
@vbraun
Copy link
Member Author

vbraun commented Jul 11, 2016

Branch: u/vbraun/ipython_5_0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

b7f84cbVarious updates, including IPython 5.0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2016

Commit: b7f84cb

@vbraun

This comment has been minimized.

@vbraun
Copy link
Member Author

vbraun commented Jul 11, 2016

Dependencies: #20923

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

d300d3bMinor updates of various python packages
b48de47Merge branch #20923 into t/21006/ipython_5_0
a571639Add prompt_toolkit, wcwidth (new IPython dependencies)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2016

Changed commit from b7f84cb to a571639

@vbraun
Copy link
Member Author

vbraun commented Jul 11, 2016

comment:6

Prompt configuration was also changed

$ ./sage
[...]
/home/vbraun/Sage/git-develop/local/lib/python2.7/site-packages/IPython/core/interactiveshell.py:440: UserWarning: As of IPython 5.0 `PromptManager` config will have no effect and has been replaced by TerminalInteractiveShell.prompts_class
  warn('As of IPython 5.0 `PromptManager` config will have no effect'
In [1]: 

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

ba7dd98Fixing hashed doct-test
34bbc13Trac #18555: Pickling and otherwise enhancing global options
82d0a8cGet rid of SAGE_ORIG_LD_LIBRARY_PATH
d3721f6Trac #20529: Get rid of SAGE_ORIG_LD_LIBRARY_PATH
5384da6Fix a bit of slight sloppiness in variable usage.
32199efTrac #20987: Minor logic fix in spkg-install for atlas
ae15a81Merge Sage 7.3.beta7 into t/21006/ipython_5_0
c99af70Add prompt_toolkit, wcwidth (new IPython dependencies)
be9a082Minor updates
d55cb77Update IPython 5.0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 11, 2016

Changed commit from a571639 to d55cb77

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 13, 2016

Changed commit from d55cb77 to ecee55f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 13, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

ecee55fUse the new IPython Prompts facilities

@vbraun
Copy link
Member Author

vbraun commented Jul 13, 2016

comment:10

IPython's run_cell() seems to be broken on Python2: ipython/ipython#9756

@kiwifb
Copy link
Member

kiwifb commented Jul 13, 2016

comment:11

Will this be the last ipython supporting python 2? I remember a post a while ago stating that a branch would be maintained for python2 but not get any new features.

@vbraun
Copy link
Member Author

vbraun commented Jul 13, 2016

comment:12

Yes, though IPython 5 is supposed to get long-term support because of that.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2016

Changed commit from ecee55f to 9314230

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 23, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

65ed9b8Test for warnings in ipython_tests
49b103cDisable new sources of ANSI codes in sage0
5d7291fRefactor IPython configuration generation
9314230Fix doctests

@vbraun
Copy link
Member Author

vbraun commented Jul 23, 2016

Author: Volker Braun

@vbraun
Copy link
Member Author

vbraun commented Jul 23, 2016

comment:14

All tests pass

@kiwifb
Copy link
Member

kiwifb commented Jul 23, 2016

comment:15

OK, I am not really ready but let's go. It's even more urgent that this also move pyzmq and I wonder how we avoided https://bugs.gentoo.org/show_bug.cgi?id=583192 for all the time that cython-0.24+ and pyzmq-15.2.0 have been in sage simultaneously.

@kiwifb
Copy link
Member

kiwifb commented Jul 23, 2016

Reviewer: François Bissey

@vbraun
Copy link
Member Author

vbraun commented Jul 24, 2016

comment:16

Since its a bigger UI change, lets postpone it to the next beta cycle.

@vbraun vbraun removed this from the sage-7.3 milestone Jul 24, 2016
@vbraun vbraun added this to the sage-7.4 milestone Jul 24, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2016

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

2313023prompt_toolkit depends on six

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 24, 2016

Changed commit from 9314230 to 2313023

@slel
Copy link
Member

slel commented Jul 28, 2016

comment:18

Just adding "upgrade" to the ticket summary so that it appears in

https://trac.sagemath.org/query?summary=~upgrade&desc=1&order=status

@slel slel changed the title IPython 5.0 Upgrade to IPython 5.0 Jul 28, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2016

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

701b91dprompt_toolkit depends on wcwidth

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 6, 2016

Changed commit from 2313023 to 701b91d

@vbraun
Copy link
Member Author

vbraun commented Aug 7, 2016

Changed branch from u/vbraun/ipython_5_0 to 701b91d

@nexttime
Copy link
Mannequin

nexttime mannequin commented Aug 11, 2016

Changed commit from 701b91d to none

@nexttime
Copy link
Mannequin

nexttime mannequin commented Aug 11, 2016

comment:22

This presumably broke sage_mode (cf. this post on sage-devel).

And this also seems related:

After the update, on exit from Sage I get

Exiting Sage (CPU time 0m0.17s, Wall time 0m44.15s).
:0: UserWarning: You do not have a working installation of the service_identity module: 'No module named service_identity'.  Please install it from <https://pypi.python.org/pypi/service_identity> and make sure all of its dependencies are satisfied.  Without the service_identity module and a recent enough pyOpenSSL to support it, Twisted can perform only rudimentary TLS client hostname verification.  Many valid certificate/hostname mappings may be rejected.

After doing "sage --pip install service_identity"
this warning goes away.

Any idea what happens here?

Dima

(from sage-release)

@nexttime
Copy link
Mannequin

nexttime mannequin commented Aug 11, 2016

comment:23

Replying to @nexttime:

This presumably broke sage_mode (cf. this post on sage-devel).

See #21227.

@jhpalmieri
Copy link
Member

comment:24

I think this also broke line_profiler:

$ sage
┌────────────────────────────────────────────────────────────────────┐
│ SageMath version 7.4.beta0, Release Date: 2016-08-10               │
│ Type "notebook()" for the browser-based notebook interface.        │
│ Type "help()" for help.                                            │
└────────────────────────────────────────────────────────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Warning: this is a prerelease version, and it may be unstable.     ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
[SageTerminalApp] WARNING | Error in loading extension: line_profiler
Check your config files in /Users/palmieri/.sage/ipython_genutils-0.1.0/profile_default
Traceback (most recent call last):
  File "/Users/palmieri/Desktop/Sage_stuff/git/sage/local/lib/python2.7/site-packages/IPython/core/shellapp.py", line 246, in init_extensions
    self.shell.extension_manager.load_extension(ext)
  File "/Users/palmieri/Desktop/Sage_stuff/git/sage/local/lib/python2.7/site-packages/IPython/core/extensions.py", line 85, in load_extension
    if self._call_load_ipython_extension(mod):
  File "/Users/palmieri/Desktop/Sage_stuff/git/sage/local/lib/python2.7/site-packages/IPython/core/extensions.py", line 132, in _call_load_ipython_extension
    mod.load_ipython_extension(self.shell)
  File "/Users/palmieri/Desktop/Sage_stuff/git/sage/local/lib/python2.7/site-packages/line_profiler.py", line 372, in load_ipython_extension
    ip.define_magic('lprun', magic_lprun)
AttributeError: 'SageTerminalInteractiveShell' object has no attribute 'define_magic'
sage: %lprun?
Object `%lprun` not found.

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Sep 9, 2016

comment:25

Replying to @jhpalmieri:

I think this also broke line_profiler:

See #21457.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants