New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change WithRealizations._an_element_ to use a_realization #21059
Comments
New commits:
|
Commit: |
comment:2
There are two failing doc-tests in
and more failures in
Not entirely sure what the policy is on doc-tests in optional packages... |
comment:3
Are these are all fixed by #21077? |
comment:4
Except for rebasing and doctests this looks good to me. I'll handle the rebasing shortly and put a positive review. |
Reviewer: Florent Hivert |
Changed keywords from none to days85 |
Changed branch from public/categories/change_an_element_with_realizations-21059 to |
Changed commit from |
As noticed on #21054, there is a discrepancy between
one
and_an_element_
for parents that are in the category*.WithRealizations
, in that the former usesa_realization
, whereas the latter usesrealizations()[0]
. While on #21054, this did uncover an error, this cases problems with the test suite when a realization does not get created beforean_element
gets called (which I have noticed before).Thus, I propose to have
_an_element_
usea_realization()
, which is a required implementation and_an_element_
will also have consistent output no matter which basis is created first.CC: @nthiery @darijgr
Component: categories
Keywords: days85
Author: Travis Scrimshaw
Branch:
f8a1bbb
Reviewer: Florent Hivert
Issue created by migration from https://trac.sagemath.org/ticket/21059
The text was updated successfully, but these errors were encountered: