Upgrade BRiAl and build it with C++11

[nexttime]

We currently work around BRiAl 0.8.5 not building in C++11 mode by passing -std=c++98, which is odd.

Fixed upstream: BRiAl/BRiAl#11

Also the patch from BRiAl/BRiAl#15 is added, which is needed for #23943.

Tarball: https://github.com/BRiAl/BRiAl/releases/download/1.0.1/brial-1.0.1.tar.bz2

Upstream: Fixed upstream, in a later stable release.

CC: @kiwifb

Component: packages: standard

Keywords: unordered_map hash_map segfault C++11

Author: Jeroen Demeyer

Branch/Commit: 2d18149

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/21083

[SnarkBoojum]

comment:2

It looks like upstream closed issue 11, and in fact version 1.0.1 is out.

[kiwifb]

comment:3

Replying to @SnarkBoojum:

It looks like upstream closed issue 11, and in fact version 1.0.1 is out.

Yes upstream is me for all that's worth [in a maintenance capacity only) and I meant to do this. Anyway those issues were technically addressed in 0.8.7, brial should compile with C++11. The only issue is that you need at least C++98. If we decide to default it to C++11 we must make sure that the sage extension is also compiled with C++11.

[jdemeyer]

Changed upstream from Reported upstream. Developers acknowledge bug. to Fixed upstream, in a later stable release.

[jdemeyer]

Branch: u/jdemeyer/upgrade_brial_and_build_it_without___std_c__98_

[jdemeyer]

Author: Jeroen Demeyer

[jdemeyer]

Commit: 82e4fca

[jdemeyer]

comment:8

Thanks to the changes to upstream, this is pretty straight-forward now.

---

New commits:

82e4fca

Upgrade BRiAl to version 1.0.1

[kiwifb]

Reviewer: François Bissey

[kiwifb]

comment:11

Looks good to me.

[vbraun]

comment:12

Fails without boost:

[brial-1.0.1] checking whether the Boost::Unit_Test_Framework library is available... yes
[brial-1.0.1] configure: error: Could not find a version of the library!
[brial-1.0.1] Error configuring BRiAl

[kiwifb]

comment:13

Right, my fault upstream when I resurrected the testsuite. I'll need to just mark the testsuite disabled if not found rather than it being mandatory.

[kiwifb]

comment:14

Actually we should be able to fix this by just adding --with-boost-unit-test-framework=no, it default to yes and assumes that it means mandatory.

[jdemeyer]

comment:15

So you mean add --with-boost-unit-test-framework=no as ./configure flag and then run the testsuite as usual?

[kiwifb]

comment:16

Replying to @jdemeyer:

So you mean add --with-boost-unit-test-framework=no as ./configure flag

Yes

and then run the testsuite as usual?

No - or yes if you consider there is currently no spkg-check for brial. You need the boost-unit-test-framework library to link the testsuite (libboost_unit_test_framework.so). And boost_cropped is just headers, no libraries so we cannot run the testsuite without the full boost package.

[jdemeyer]

comment:17

I think I understand. The BRiAl build in Sage fails because it doesn't find the boost unit testing framework. However, since Sage doesn't run the testsuite, it doesn't actually need boost at all.

[kiwifb]

comment:18

It still needs boost headers (boost_cropped), they are used in brial in several places. But the test suite relies on something that is only built with the full boost.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2d18149

Disable test suite, which requires Boost

[sagetrac-git]

Changed commit from 82e4fca to 2d18149

[kiwifb]

comment:21

Looks good.

[vbraun]

Changed branch from u/jdemeyer/upgrade_brial_and_build_it_without___std_c__98_ to 2d18149