sage.structure.debug_options should be cimported

[jdemeyer]

Obvious low-hanging optimization fruit.

Component: performance

Author: Jeroen Demeyer

Branch/Commit: fb6ef31

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/21096

[jdemeyer]

Branch: u/jdemeyer/sage_structure_debug_options_should_be_cimported

[jdemeyer]

New commits:

fb6ef31

sage.structure.debug_options should be cimported

[jdemeyer]

Commit: fb6ef31

[mezzarobba]

comment:3

LGTM, but I imagined this was intended to speed up parent creation, and I couldn't find an example where it made a measurable difference. Do you have one?

[mezzarobba]

Reviewer: Marc Mezzarobba

[jdemeyer]

comment:4

Replying to @mezzarobba:

LGTM, but I imagined this was intended to speed up parent creation, and I couldn't find an example where it made a measurable difference. Do you have one?

I don't think so. Anyway, this is a relatively old ticket and I don't remember the reason for creating the ticket. Probably it was just an easy fix that I saw.

And by the way, this ugliness

from cpython.object cimport PyObject
cdef extern from *:
    PyObject* __pyx_d

(<object>__pyx_d)["debug"] = debug

will be better once Cython 0.25 comes out.

[vbraun]

Changed branch from u/jdemeyer/sage_structure_debug_options_should_be_cimported to fb6ef31