New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rubiks' patches to conform to same format as other patches #21103
Comments
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
This comment has been minimized.
This comment has been minimized.
comment:5
I am not really convinced that the non-patched
|
comment:6
Compare to the current source. For the makefiles I removed from the patch there is no longer any difference from upstream (which has probably been patched). |
comment:7
Actually scratch that, I was confused. I don't think those patches were supposed to be removed. You can update the commit to not remove the makefile patches (just the full makefile copies). |
comment:8
With the branch on this ticket, What is considered upstream for this package? Should there be an |
comment:9
I think all this needs to is roll back the removal of
from the commit. They shouldn't have been removed. |
comment:12
This now works for me. If you're happy with this, then you can it to positive_review. |
Changed author from Erik Bray to Erik Bray, Jeroen Demeyer |
Reviewer: Jeroen Demeyer, Erik Bray |
comment:13
comment 8. |
comment:14
Replying to @mkoeppe:
I don't really care about that. It's unrelated to this ticket anyway. |
Changed reviewer from Jeroen Demeyer, Erik Bray to Jeroen Demeyer, Erik Bray, Matthias Koeppe |
Changed branch from u/jdemeyer/update_rubiks__patches_to_conform_to_same_format_as_other_patches to |
comment:18
Thanks! |
Changed commit from |
The
rubiks
package is copying files instead of proper patching. Clean this up.See also #20837 and #20933 which did the same for other packages.
CC: @embray
Component: packages: standard
Author: Erik Bray, Jeroen Demeyer
Branch:
87963a9
Reviewer: Jeroen Demeyer, Erik Bray, Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/21103
The text was updated successfully, but these errors were encountered: