Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not use has_key (not python3 compatible) #21107

Closed
fchapoton opened this issue Jul 27, 2016 · 6 comments
Closed

do not use has_key (not python3 compatible) #21107

fchapoton opened this issue Jul 27, 2016 · 6 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-7.3

Comments

@fchapoton
Copy link
Contributor

replaced by the correct syntax "a in dict"

re-playing #15784

CC: @tscrim @jm58660 @jdemeyer

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 594e621

Reviewer: André Apitzsch

Issue created by migration from https://trac.sagemath.org/ticket/21107
@fchapoton fchapoton added this to the sage-7.3 milestone Jul 27, 2016
@fchapoton
Copy link
Contributor Author

New commits:

594e621has_key is not allowed in python3

@fchapoton
Copy link
Contributor Author

Branch: public/21107

@fchapoton
Copy link
Contributor Author

Commit: 594e621

@a-andre
Copy link

a-andre commented Jul 27, 2016

comment:2

LGTM.

@a-andre
Copy link

a-andre commented Jul 27, 2016

Reviewer: André Apitzsch

@vbraun
Copy link
Member

vbraun commented Jul 28, 2016

Changed branch from public/21107 to 594e621

@vbraun vbraun closed this as completed in a209cc4 Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.3
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @a-andre