Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flattening in quo_rem #21108

Closed
videlec opened this issue Jul 27, 2016 · 18 comments
Closed

Use flattening in quo_rem #21108

videlec opened this issue Jul 27, 2016 · 18 comments

Comments

@videlec
Copy link
Contributor

videlec commented Jul 27, 2016

Using the flattening morphism from #21106 we can divide more polynomials! With the branch applied the following works

sage: R = QQ['a','b']['c','d']
sage: R('(a*b+1)*c + c^2').quo_rem(R('c'))
(c + a*b + 1, 0)

However, will persist a discrepency between QQ['a']['b']['c'] and QQ['a','b','c'] when the division is not exact.

sage: R1 = QQ['a']['b']['c']
sage: R2 = QQ['a','b','c']
sage: R1('a').quo_rem(R1('b'))
Traceback (most recent call last):
...
ArithmeticError: Division non exact (consider coercing
to polynomials over the fraction field)
sage: R2('a').quo_rem(R2('b'))
(0, a)

See this sage-devel thread.

Depends on #21106

CC: @bhutz

Component: algebra

Author: Vincent Delecroix

Branch: a593121

Reviewer: Ben Hutz

Issue created by migration from https://trac.sagemath.org/ticket/21108

@videlec videlec added this to the sage-7.3 milestone Jul 27, 2016
@videlec

This comment has been minimized.

@videlec
Copy link
Contributor Author

videlec commented Jul 27, 2016

Commit: d9afab6

@videlec
Copy link
Contributor Author

videlec commented Jul 27, 2016

Branch: u/vdelecroix/21108

@videlec
Copy link
Contributor Author

videlec commented Jul 27, 2016

New commits:

cf97fed21106: create polynomial ring flattening class
957589f21106: minor fixes
8c22f7521106: new version of _call_
570d9ee21106: added doc tests
f05f7db21106:cleaning
6e5094221106: change file mode
19cb17121106: Python3 compatibility + more cleaning
d7b066d21108: method flattening_morphism
d9afab621108: use flattening in quo_rem

@videlec
Copy link
Contributor Author

videlec commented Jul 27, 2016

Author: Vincent Delecroix

@bhutz
Copy link

bhutz commented Jul 27, 2016

Changed branch from u/vdelecroix/21108 to u/bhutz/21108

@bhutz
Copy link

bhutz commented Jul 27, 2016

Changed branch from u/bhutz/21108 to u/vdelecroix/21108

@bhutz
Copy link

bhutz commented Jul 27, 2016

comment:4

Looks fine to me. All test pan out.

Note that fixing the quo_rem resolves the issue in #21100. So I've included a commit with that example to test that issue. We can then close that ticket as resolved or whatever is appropriate.

If you're fine with the example, this can be marked positive-review.

@bhutz
Copy link

bhutz commented Jul 27, 2016

Reviewer: Ben Hutz

@bhutz
Copy link

bhutz commented Jul 27, 2016

Changed branch from u/vdelecroix/21108 to u/bhutz/21108

@bhutz
Copy link

bhutz commented Jul 27, 2016

Changed commit from d9afab6 to a593121

@bhutz
Copy link

bhutz commented Jul 27, 2016

New commits:

a59312121108: add normalaize_coordinates example

@videlec

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Aug 13, 2016

Changed branch from u/bhutz/21108 to a593121

@xcaruso
Copy link
Contributor

xcaruso commented Jan 4, 2021

Changed branch from a593121 to u/caruso/a5931218dac6be179f0338df0e3ce8e4793896c1

@xcaruso
Copy link
Contributor

xcaruso commented Jan 4, 2021

comment:10

Sorry, I made a typo and pushed on this ticket instead of #31108

@xcaruso
Copy link
Contributor

xcaruso commented Jan 4, 2021

Changed commit from a593121 to none

@xcaruso
Copy link
Contributor

xcaruso commented Jan 4, 2021

Changed branch from u/caruso/a5931218dac6be179f0338df0e3ce8e4793896c1 to a593121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants