New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use flattening in quo_rem #21108
Comments
This comment has been minimized.
This comment has been minimized.
Commit: |
Branch: u/vdelecroix/21108 |
New commits:
|
Author: Vincent Delecroix |
Changed branch from u/vdelecroix/21108 to u/bhutz/21108 |
Changed branch from u/bhutz/21108 to u/vdelecroix/21108 |
comment:4
Looks fine to me. All test pan out. Note that fixing the quo_rem resolves the issue in #21100. So I've included a commit with that example to test that issue. We can then close that ticket as resolved or whatever is appropriate. If you're fine with the example, this can be marked positive-review. |
Reviewer: Ben Hutz |
Changed branch from u/vdelecroix/21108 to u/bhutz/21108 |
New commits:
|
This comment has been minimized.
This comment has been minimized.
Changed branch from u/bhutz/21108 to |
Changed branch from |
comment:10
Sorry, I made a typo and pushed on this ticket instead of #31108 |
Changed commit from |
Changed branch from u/caruso/a5931218dac6be179f0338df0e3ce8e4793896c1 to |
Using the flattening morphism from #21106 we can divide more polynomials! With the branch applied the following works
However, will persist a discrepency between
QQ['a']['b']['c']
andQQ['a','b','c']
when the division is not exact.See this sage-devel thread.
Depends on #21106
CC: @bhutz
Component: algebra
Author: Vincent Delecroix
Branch:
a593121
Reviewer: Ben Hutz
Issue created by migration from https://trac.sagemath.org/ticket/21108
The text was updated successfully, but these errors were encountered: