Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unflattening morphim error #21113

Closed
bhutz opened this issue Jul 28, 2016 · 15 comments
Closed

unflattening morphim error #21113

bhutz opened this issue Jul 28, 2016 · 15 comments
Labels
c: algebra p: minor / 4 t: bug
Milestone
sage-7.4

Comments

@bhutz
Copy link

bhutz commented Jul 28, 2016

UnflatteningMorphism cannot be used by itself since the attribute _intermediate rings is defined through the method section of FlatteningMorphism.

Depends on #21106

CC: @videlec

Component: algebra

Author: Ben Hutz

Branch/Commit: 4b083ad

Reviewer: Vincent Delecroix, Paul Fili

Issue created by migration from https://trac.sagemath.org/ticket/21113
@bhutz bhutz added this to the sage-7.3 milestone Jul 28, 2016
@bhutz
Copy link
Author

bhutz commented Jul 28, 2016

Branch: u/bhutz/unflattening

@bhutz
Copy link
Author

bhutz commented Jul 28, 2016

New commits:

cf97fed21106: create polynomial ring flattening class
957589f21106: minor fixes
8c22f7521106: new version of _call_
570d9ee21106: added doc tests
f05f7db21106:cleaning
6e5094221106: change file mode
19cb17121106: Python3 compatibility + more cleaning
ed4588721113: add init for UnflatteningMorphism

@bhutz
Copy link
Author

bhutz commented Jul 28, 2016

Commit: ed45887

@videlec

This comment has been minimized.

Sign in to view
@videlec
Copy link
Contributor

videlec commented Jul 28, 2016

comment:3

It would be good to check (and doctest) that:

  • domain is a MPolynomialRing
  • that the base ring of domain is the base ring of the last element of intermediate_ring
  • that the number of variables match

@videlec
Copy link
Contributor

videlec commented Jul 28, 2016

Dependencies: #21106

@videlec
Copy link
Contributor

videlec commented Jul 28, 2016

Reviewer: Vincent Delecroix

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 28, 2016

Changed commit from ed45887 to 211ea03

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 28, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

211ea0321113: add input checks

@bhutz
Copy link
Author

bhutz commented Jul 28, 2016

Author: Ben Hutz

@pfili
Copy link

pfili commented Jul 29, 2016

Changed branch from u/bhutz/unflattening to u/paulfili/unflattening

@pfili
Copy link

pfili commented Jul 29, 2016

New commits:

4b083ad21113: corrected one typographical error

@pfili
Copy link

pfili commented Jul 29, 2016

Changed reviewer from Vincent Delecroix to Vincent Delecroix, Paul Fili

@pfili
Copy link

pfili commented Jul 29, 2016

Changed commit from 211ea03 to 4b083ad

@pfili pfili modified the milestones: sage-7.3, sage-7.4 Jul 29, 2016
@vbraun
Copy link
Member

vbraun commented Aug 10, 2016

Changed branch from u/paulfili/unflattening to 4b083ad

@vbraun vbraun closed this as completed in ab2dbc9 Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebra p: minor / 4 t: bug
Projects
None yet
Milestone
sage-7.4
Development

No branches or pull requests
4 participants
@vbraun @videlec @pfili @bhutz