Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATLAS spkg doesn't need /Sage's/ python to build #21114

Closed
nexttime mannequin opened this issue Jul 28, 2016 · 4 comments
Closed

ATLAS spkg doesn't need /Sage's/ python to build #21114

nexttime mannequin opened this issue Jul 28, 2016 · 4 comments

Comments

@nexttime
Copy link
Mannequin

nexttime mannequin commented Jul 28, 2016

Since we meanwhile require a system python to let Sage build anyway, we don't have to wait with building ATLAS until Sage's python has been built, as ATLAS doesn't install any Python libraries, but only its spkg-install has been rewritten in Python quite a while ago.

This requires two things:

  • Remove the dependency of ATLAS on $(PYTHON) (which means Sage's python2 or python3 package) in its dependencies.

  • Make ATLAS' spkg-install again a shell script, renaming the current one to spkg-install.py, say, where the shell script just contains

#!/bin/sh
exec python spkg-install.py

This is necessary because sage-spkg checks whether Sage's python is already installed if an spkg-install script starts with #! ... python, and bails out otherwise:

atlas-3.10.2.p2
====================================================
Setting up build directory for atlas-3.10.2.p2
Finished set up
Error: The spkg-install script is written in Python, but the Python
package is not yet installed in Sage.  You should add $(PYTHON)
as dependency in build/pkgs/atlas/dependencies
make[2]: *** [.../sage/local/var/lib/sage/installed/atlas-3.10.2.p2] Error 1

(Note that this message originates from a build where the Makefile was broken, such that the make dependency of ATLAS on the python package was fulfilled by $(PYTHON) accidentally being empty. So one won't get this message unless the Makefile is corrupted.)


Rather orthogonal to that, our top-level configure doesn't contain any check for python yet, although currently at least sage-download-file and sage-uncompress-spkg require (a system) python (in the beginning of the build). I'll address that on another ticket -- see #21116.

Depends on #30350

CC: @vbraun

Component: packages: standard

Keywords: sage-spkg dependencies spkg-install

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/21114

@nexttime nexttime mannequin added this to the sage-7.3 milestone Jul 28, 2016
@nexttime

This comment has been minimized.

@mkoeppe
Copy link
Member

mkoeppe commented Sep 25, 2021

comment:2

outdated after atlas spkg removal in #30350

@mkoeppe
Copy link
Member

mkoeppe commented Sep 25, 2021

Dependencies: #30350

@mkoeppe mkoeppe removed this from the sage-7.3 milestone Sep 25, 2021
@orlitzky
Copy link
Contributor

orlitzky commented Oct 4, 2021

Reviewer: Michael Orlitzky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants