Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'make <package>' shouldn't always say "Sage build/upgrade complete!" #21134

Open
nexttime mannequin opened this issue Jul 30, 2016 · 1 comment
Open

'make <package>' shouldn't always say "Sage build/upgrade complete!" #21134

nexttime mannequin opened this issue Jul 30, 2016 · 1 comment

Comments

@nexttime
Copy link
Mannequin

nexttime mannequin commented Jul 30, 2016

If for example a full build of Sage got interrupted or failed, and one afterwards does

make some_package

and the latter succeeded, one at the end gets

Sage build/upgrade complete!

even though Sage isn't yet fully built.

(This message comes from build/make/install, a shell script called from the top-level Makefile, which in turn invokes make on build/make/Makefile.)


We could check $1 also before printing that message, and/or add

if $MAKE -q "$target" >/dev/null 2>/dev/null; then
    # $target is up-to-date 
    ...
else
    # $target hasn't fully been built yet
    ...
fi

there again (with target=all or probably =all-build).

Also, the hint on installing scripts should now be given if $1 = all-build as well.
(We could perhaps move it into the Makefile / deps anyway.)

CC: @jdemeyer

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/21134

@nexttime nexttime mannequin added this to the sage-7.4 milestone Jul 30, 2016
@nexttime nexttime mannequin added c: build labels Jul 30, 2016
@nexttime
Copy link
Mannequin Author

nexttime mannequin commented Aug 7, 2016

comment:1

Even after just downloading an upstream package tarball (./sage -i -d <package>), Sage afterwards says "Sage build/upgrade complete", which is simply plain wrong and misleading.

@mkoeppe mkoeppe removed this from the sage-7.4 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant