Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building the doc produces deprecation warning #21146

Closed
videlec opened this issue Aug 1, 2016 · 10 comments
Closed

Building the doc produces deprecation warning #21146

videlec opened this issue Aug 1, 2016 · 10 comments
Labels
c: documentation p: major / 3 t: enhancement
Milestone
sage-7.3

Comments

@videlec
Copy link
Contributor

videlec commented Aug 1, 2016

When building the doc we got

[dochtml] [plotting ] <string>:7: DeprecationWarning: Use of vertex_colors=<string> is deprecated, use vertex_color=<string> and/or vertex_colors=<dict>.
[dochtml] [plotting ] See http://trac.sagemath.org/21048 for details.

(of course due to #21048). Would be better to fix it.

CC: @jm58660 @paulmasson

Component: documentation

Author: Paul Masson

Branch/Commit: 4c8e69c

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/21146
@videlec videlec added this to the sage-7.3 milestone Aug 1, 2016
@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Aug 2, 2016

Branch: u/paulmasson/21146

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Aug 2, 2016

comment:2

Done.

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Aug 2, 2016

Author: Paul Masson

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Aug 2, 2016

Commit: c4f3c93

@paulmasson paulmasson mannequin added the s: needs review label Aug 2, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 2, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

4c8e69cFix DeprecationWarning

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 2, 2016

Changed commit from c4f3c93 to 4c8e69c

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Aug 2, 2016

comment:4

May take more than 10 days for me to review this.

Don't we have patchbot plugin for there kind of errors?

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:5

Looks good. Thanks.

@vbraun
Copy link
Member

vbraun commented Aug 7, 2016

Changed branch from u/paulmasson/21146 to 4c8e69c

@vbraun vbraun closed this as completed in 9b3bbda Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.3
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @videlec