Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement unary operations in interfaces #21152

Closed
jdemeyer opened this issue Aug 3, 2016 · 6 comments
Closed

Implement unary operations in interfaces #21152

jdemeyer opened this issue Aug 3, 2016 · 6 comments
Labels
c: interfaces p: major / 3 t: enhancement
Milestone
sage-7.3

Comments

@jdemeyer
Copy link

jdemeyer commented Aug 3, 2016

Currently, Sage relies on the default implementations from RingElement for unary operations for interface elements. Instead, we should directly implement unary operations in InterfaceElement analogous to the binary operations. Maxima already does this.

Component: interfaces

Author: Jeroen Demeyer

Branch/Commit: 12d9d32

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/21152
@jdemeyer jdemeyer added this to the sage-7.3 milestone Aug 3, 2016
@jdemeyer
Copy link
Author

jdemeyer commented Aug 3, 2016

Branch: u/jdemeyer/ticket/21152

@jdemeyer
Copy link
Author

jdemeyer commented Aug 3, 2016

New commits:

12d9d32Implement unary operations in interfaces

@jdemeyer
Copy link
Author

jdemeyer commented Aug 3, 2016

Commit: 12d9d32

@tscrim
Copy link
Collaborator

tscrim commented Aug 4, 2016

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Aug 4, 2016

comment:3

LGTM.

@vbraun
Copy link
Member

vbraun commented Aug 7, 2016

Changed branch from u/jdemeyer/ticket/21152 to 12d9d32

@vbraun vbraun closed this as completed in f57c40a Aug 7, 2016
This was referenced Oct 3, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.3
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer