Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poset documentation polishing: Graphs #21197

Closed
jm58660 mannequin opened this issue Aug 9, 2016 · 16 comments
Closed

Poset documentation polishing: Graphs #21197

jm58660 mannequin opened this issue Aug 9, 2016 · 16 comments

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Aug 9, 2016

Check documentation for poset functions that returns a (di)graph.

Changes are minor things, just unifying some wording, moving examples that are clearly tests to tests-block etc. Also

  • Remove wrapped-parameter from hasse_diagram(), as it did nothing.
  • Fix typo in lattices.py, "quantum" was in wrong place.
  • Move breath() last in list in lattices.py, as other functions return a Boolean value.

This continues the serie of #18925, #18941, #18959, #19141, #19360, #19435.

CC: @kevindilks @darijgr

Component: documentation

Author: Jori Mäntysalo

Branch/Commit: cd39820

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/21197

@jm58660 jm58660 mannequin added this to the sage-7.4 milestone Aug 9, 2016
@jm58660 jm58660 mannequin added c: documentation labels Aug 9, 2016
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Aug 9, 2016

Branch: u/jmantysalo/poset-graphs

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

de0e9dbSome bikeshedding to poset functions that return a graph.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2016

Commit: de0e9db

@jm58660

This comment has been minimized.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Aug 11, 2016

comment:3

Kevin, I am continuing this serie. Compiling now, so not ready for review yet.

Darij: An example in frank_network contains numbers 12, -13, 14 and 16. Is there some reason for that?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

cd39820A correction.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2016

Changed commit from de0e9db to cd39820

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Aug 24, 2016

comment:5

Kevin, maybe you can check this; we can check come back to frank_network later.

...polynomials next... this serie seems to take a year or two.

@jm58660 jm58660 mannequin added the s: needs review label Aug 24, 2016
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 6, 2016

comment:6

Just pinging.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:7

ok, let it be. Even if I do not see the point of changing all the doctests..

@kevindilks
Copy link
Mannequin

kevindilks mannequin commented Sep 6, 2016

comment:8

Are you able to run the doctests? After applying this ticket, I was able to run doctests for unchanged files and lattices.py, but when I tried to test posets.py it just hangs until I force quit, where it shows it was using 0 CPU time. Currently upgrading from 7.4beta1 to 7.3beta3 to see if that makes a difference.

@fchapoton
Copy link
Contributor

comment:9

hum, one patchbot is happy with the doctests, so I did not double check.

There was a problem indeed about some test in posets.py in 7.4.beta(1-2), that has been solved in 7.4.b3

@kevindilks
Copy link
Mannequin

kevindilks mannequin commented Sep 6, 2016

comment:10

Alright, I just finished updating to 7.4b3 and it does work now.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Sep 7, 2016

comment:11

Thanks!

I am gradually checking posets.py, and trying to make meaningful examples in the process. Next will be polynomials; for example order_polynomial() should use as_ideals=False when calling order_ideals_lattice() and so on.

@vbraun
Copy link
Member

vbraun commented Sep 8, 2016

Changed branch from u/jmantysalo/poset-graphs to cd39820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants