New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poset documentation polishing: Graphs #21197
Comments
Branch: u/jmantysalo/poset-graphs |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Commit: |
This comment has been minimized.
This comment has been minimized.
comment:3
Kevin, I am continuing this serie. Compiling now, so not ready for review yet. Darij: An example in |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:5
Kevin, maybe you can check this; we can check come back to ...polynomials next... this serie seems to take a year or two. |
comment:6
Just pinging. |
Reviewer: Frédéric Chapoton |
comment:7
ok, let it be. Even if I do not see the point of changing all the doctests.. |
comment:8
Are you able to run the doctests? After applying this ticket, I was able to run doctests for unchanged files and |
comment:9
hum, one patchbot is happy with the doctests, so I did not double check. There was a problem indeed about some test in posets.py in 7.4.beta(1-2), that has been solved in 7.4.b3 |
comment:10
Alright, I just finished updating to 7.4b3 and it does work now. |
comment:11
Thanks! I am gradually checking |
Changed branch from u/jmantysalo/poset-graphs to |
Check documentation for poset functions that returns a (di)graph.
Changes are minor things, just unifying some wording, moving examples that are clearly tests to tests-block etc. Also
wrapped
-parameter fromhasse_diagram()
, as it did nothing.lattices.py
, "quantum" was in wrong place.breath()
last in list inlattices.py
, as other functions return a Boolean value.This continues the serie of #18925, #18941, #18959, #19141, #19360, #19435.
CC: @kevindilks @darijgr
Component: documentation
Author: Jori Mäntysalo
Branch/Commit:
cd39820
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/21197
The text was updated successfully, but these errors were encountered: