Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3 import for cPickle (moved) #21225

Closed
fchapoton opened this issue Aug 11, 2016 · 13 comments
Closed

py3 import for cPickle (moved) #21225

fchapoton opened this issue Aug 11, 2016 · 13 comments

Comments

@fchapoton
Copy link
Contributor

as another step towards python3 compatibility

CC: @tscrim @jm58660 @jdemeyer

Component: python3

Author: Frédéric Chapoton

Branch/Commit: dccec82

Reviewer: André Apitzsch

Issue created by migration from https://trac.sagemath.org/ticket/21225

@fchapoton fchapoton added this to the sage-7.4 milestone Aug 11, 2016
@fchapoton
Copy link
Contributor Author

New commits:

755db27py3 compatible imports for cPickle

@fchapoton
Copy link
Contributor Author

Branch: public/21225

@fchapoton
Copy link
Contributor Author

Commit: 755db27

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2016

Changed commit from 755db27 to ec8819a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

ec8819atrac 21225 adding one absolute_import

@a-andre
Copy link

a-andre commented Aug 11, 2016

comment:3

You probably won't include the changes to src/sage/rings/polynomial/term_order.py here?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

dccec82py3 compatible imports for cPickle

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 11, 2016

Changed commit from ec8819a to dccec82

@fchapoton
Copy link
Contributor Author

comment:5

oops, sorry for that, doing too many things at the same time

@a-andre
Copy link

a-andre commented Aug 11, 2016

Reviewer: André Apitzsch

@a-andre
Copy link

a-andre commented Aug 11, 2016

comment:7

LGTM.

@fchapoton
Copy link
Contributor Author

comment:8

Thanks. There is a follow-up at #16069, if you have time.

@vbraun
Copy link
Member

vbraun commented Aug 13, 2016

Changed branch from public/21225 to dccec82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants