New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
faq-usage typo 'preparse' should be 'preparser' #21241
Comments
comment:1
done, please review. New commits:
|
Author: Frédéric Chapoton |
Commit: |
Branch: public/21241 |
Reviewer: Paul Masson |
comment:2
In the next sentence please change "can may" to "can" and ". Or switching" to " or switch" for correct grammar. There are two other instances of "preparse(" in this file on L286 and L333 which are correct. |
comment:3
Also, |
comment:4
Please also let me know for future reference whether it's simpler for me to make changes like this on a public branch and then have you review them. Happy to do so if that's a better work flow. |
comment:5
References to "preparse(): at L286 and L333 are correct. There are two similarly-named functions. First parameter to preparse() is a line of code. Parameter to preparser() is a boolean. |
comment:6
Replying to @DrXyzzy:
Right you are. Sorry for the confusion. Will update previous comment. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
done. The import of line 301 still works, so does not need to be changed. |
Changed branch from public/21241 to |
In src/doc/en/faq/faq-usage.rst around line 362, text says
This should read
Example: try the following in sage command line session. It fails with an exception.
But this succeeds and produces output:
Component: documentation
Keywords: faq-usage faq preparser preparse
Author: Frédéric Chapoton
Branch/Commit:
72c48d1
Reviewer: Paul Masson
Issue created by migration from https://trac.sagemath.org/ticket/21241
The text was updated successfully, but these errors were encountered: