Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: do not use file(filename, type) #21246

Closed
fchapoton opened this issue Aug 14, 2016 · 6 comments
Closed

py3: do not use file(filename, type) #21246

fchapoton opened this issue Aug 14, 2016 · 6 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-7.4

Comments

@fchapoton
Copy link
Contributor

but use open(filename, type) instead

CC: @tscrim @jdemeyer @a-andre

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 3f169d0

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/21246
@fchapoton fchapoton added this to the sage-7.4 milestone Aug 14, 2016
@fchapoton
Copy link
Contributor Author

New commits:

3f169d0py3: no longer use file(name, kind)

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/21246

@fchapoton
Copy link
Contributor Author

Commit: 3f169d0

@jdemeyer
Copy link

comment:2

If this passes doctests, this can have positive_review from me.

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@vbraun
Copy link
Member

vbraun commented Aug 17, 2016

Changed branch from u/chapoton/21246 to 3f169d0

@vbraun vbraun closed this as completed in 27d75dc Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.4
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @fchapoton