py3: get rid of iterkeys

[fchapoton]

as a step towards py3, do not use iterkeys

(there remains 3 more subtle uses of iterkeys)

I have also taken the opprtunity to remove deprecated code in src/sage/combinat/finite_state_machine.py

CC: @cheuberg

Component: python3

Author: Frédéric Chapoton

Branch: 4a3b20f

Reviewer: Jori Mäntysalo

Issue created by migration from https://trac.sagemath.org/ticket/21266

[fchapoton]

Commit: 12a7c62

[fchapoton]

New commits:

12a7c62

py3: getting rid of iterkeys()

[fchapoton]

Branch: u/chapoton/21266

[jm58660]

comment:3

I can check this.

[jm58660]

Reviewer: Jori Mäntysalo

[jm58660]

comment:4

Otherwise there are no problems, but I got an doctest error from _color_by_label() of generic_graph.py.

I guess that happens because of change at src/sage/graphs/base/c_graph.pyx, but of course the real problem is getting a list when we mathematically have a set. I suggest you change docstring to have some in statements (see for example test block of is_dismantlable() on lattices.py) or use sorted(). It is enought for a function starting with _.

(And I think that this is a real problem for example blocks on some functions.)

[sagetrac-git]

Changed commit from 12a7c62 to 4a3b20f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3c85228	Merge branch 'u/chapoton/21266' in 7.4.b1
4a3b20f	trac 21266 trying to fix doctests in generic_graph color_by_label

[fchapoton]

comment:6

Does this fix the problem ?

[fchapoton]

comment:7

seems ok now

[jm58660]

comment:8

Replying to @fchapoton:

Does this fix the problem ?

Yes.

[vbraun]

Changed branch from u/chapoton/21266 to 4a3b20f

[dkrenn]

comment:10

Thanks for the clean-up in finite_state_machines. :)

[dkrenn]

Changed commit from 4a3b20f to none