Cleanup in sparse modules

[sagetrac-Bouillaguet]

This ticket removes all the .pxi files in sage/modules, and replaces them by proper .pxd/pyx files.

It adds no new functionnality, but seems to be required to have a C++ binding to linbox.

CC: @ClementPernet

Component: linear algebra

Keywords: sd75

Author: Charles Bouillaguet

Branch/Commit: ce4de73

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/21321

[sagetrac-Bouillaguet]

Branch: u/Bouillaguet/module_pxi_must_die

[ClementPernet]

New commits:

0d50a4e

removes .pxi files in sage/modules, replace by .pyx/pxd

[ClementPernet]

Commit: 0d50a4e

[ClementPernet]

Changed keywords from none to sd75

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

1126d8a	forgot module_list.py
fd3ee8c	convert modules/vector_rational_sparse.pxi
b6bc054	Merge commit 'fd3ee8c9a45b75c5384546166496622d6a860f15' into develop
e5c8348	fix vector_rational_sparse
a31fc69	convert module/vector_integer_sparse.pxi
855a549	Merge commit 'a31fc697619288b58799a3edb80d41bf070c3d50' into develop
ef6eece	fixed vector_integer_sparse
f0c88db	convert modules/vector_modn_sparse.pxi
2d7ee59	Merge branch 'modules_pxi_must_die_hard' into develop
a32caee	fixed vector_modn_sparse

[sagetrac-git]

Changed commit from 0d50a4e to a32caee

[sagetrac-Bouillaguet]

Changed author from Bouillaguet to Charles Bouillaguet

[sagetrac-git]

Changed commit from a32caee to 206e794

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

206e794

Fixed a remaining reference to vector_modn_sparse.pxi

[jdemeyer]

comment:7

I might review this.

[jdemeyer]

comment:8

One thing: you have a very complicated git history here. Can you squash it to just 1 commit?

[jdemeyer]

comment:9

cysignals stuff should only be in .pyx files.

[jdemeyer]

comment:10

More generally, .pxd files should only cimport/include what they really need.

[jdemeyer]

comment:11

Did you check for conflicts with #17635?

[sagetrac-git]

Changed commit from 206e794 to 2036d22

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

305adf6	sqome more typos
72730d6	Updated [SageMath](../wiki/SageMath) version to 7.4.beta1
2036d22	Convert .pxi files in sage/modules/ into proper .pxd/.pyx files

[sagetrac-Bouillaguet]

comment:13

Thanks for your time, Jeroen. I fixed the extra imports in .pxd files, and sqashed all that into a single commit. Up for review again.

[jdemeyer]

comment:14

Replying to @sagetrac-Bouillaguet:

and sqashed all that into a single commit.

I think you did something wrong, since I see two unrelated commits. In any case, you should rebase on top of sage-7.4.beta2 now.

[jdemeyer]

Reviewer: Jeroen Demeyer

[ClementPernet]

comment:15

Replying to @jdemeyer:

Did you check for conflicts with #17635?

This ticket merges cleanly with 17635 and the testsuite passes on my box.

[jdemeyer]

comment:16

Since you're moving files anyway, could you move src/sage/modules/binary_search to src/sage/data_structures/binary_search. That code has nothing to do with modules.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b706613

Convert .pxi files in sage/modules/ into proper .pxd/.pyx files

[sagetrac-git]

Changed commit from 2036d22 to b706613

[sagetrac-git]

Changed commit from b706613 to ce4de73

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ce4de73

moved sage.modules.binary_search to sage.data_structures.binary_search

[sagetrac-Bouillaguet]

comment:19

Jeroen, the ticket is ready for review (again).

[jdemeyer]

comment:20

Did you run full doctests with this latest patch?

[sagetrac-Bouillaguet]

comment:21

No. I'm counting on the patchbot...

[jdemeyer]

comment:22

Tests are good.

[vbraun]

Changed branch from u/Bouillaguet/module_pxi_must_die to ce4de73