Simplify _populate_generators_

[jdemeyer]

1. The argument category is never used.

2. gens is never None.

3. We can get rid of _ngens_ which appears only in _populate_generators_ but is never actually called.

(see also the task ticket: #21380)

CC: @videlec @tscrim

Component: categories

Author: Jeroen Demeyer

Branch/Commit: 079a1d4

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/21381

[jdemeyer]

Branch: u/jdemeyer/simplify__populate_generators_

[jdemeyer]

Commit: 079a1d4

[jdemeyer]

New commits:

079a1d4

Simplify _populate_generators_

[tscrim]

comment:5

Could move the entire logic into that branch Parent. _populate_generators_ is only called there and never overriden/used elsewhere?

[videlec]

comment:6

Replying to @tscrim:

Could move the entire logic into that branch Parent. _populate_generators_ is only called there and never overriden/used elsewhere?

I would prefer keeping all the generators stuff into one place (for now CategoryObject). Starting splitting it between CategoryObject and Parent will make it harder for #21380.

[jdemeyer]

comment:7

Replying to @tscrim:

Could move the entire logic into that branch Parent. _populate_generators_ is only called there and never overriden/used elsewhere?

Can we stick to just the contents of this ticket? We can still move it later.

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:8

Alright.

[vbraun]

Changed branch from u/jdemeyer/simplify__populate_generators_ to 079a1d4