Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: remove one cmp in matrix2 #21414

Closed
fchapoton opened this issue Sep 4, 2016 · 6 comments
Closed

py3: remove one cmp in matrix2 #21414

fchapoton opened this issue Sep 4, 2016 · 6 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-7.4

Comments

@fchapoton
Copy link
Contributor

as a step to py3, let us use a key to sort, not cmp

CC: @tscrim @jdemeyer @a-andre

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 700320e

Reviewer: André Apitzsch

Issue created by migration from https://trac.sagemath.org/ticket/21414
@fchapoton fchapoton added this to the sage-7.4 milestone Sep 4, 2016
@fchapoton
Copy link
Contributor Author

comment:1

easy little ticket

New commits:

700320econvert one comparison to use key (in matrix2)

@fchapoton
Copy link
Contributor Author

Branch: public/21414

@fchapoton
Copy link
Contributor Author

Commit: 700320e

@a-andre
Copy link

a-andre commented Sep 4, 2016

comment:2

I think it doesn't matter whether it's list.sort(v) or v.sort(); that's why positive review.

@a-andre
Copy link

a-andre commented Sep 4, 2016

Reviewer: André Apitzsch

@vbraun
Copy link
Member

vbraun commented Sep 8, 2016

Changed branch from public/21414 to 700320e

@vbraun vbraun closed this as completed in f04648c Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.4
Development

No branches or pull requests
3 participants
@vbraun @fchapoton @a-andre