New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jupyter-kernel-gap package #21416
Comments
Commit: |
This comment has been minimized.
This comment has been minimized.
New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:9
I wonder why this cannot be a package of type |
comment:10
Anyhow, this appears to work. I'll check this on OSX, too. |
comment:11
for some reason, the log is very chatty (on OSX):
it still all seems to work, but it's good to understand how harmless this is. |
comment:12
same picture on Linux; here I open a new jupyter notebook and evaluate
it looks as if json parsing is a problem here. Wrong json or wrong parser? |
Upstream: Reported upstream. Developers acknowledge bug. |
comment:13
Upstream acknowledges bug but doesn't care... |
comment:14
according to https://github.com/gap-packages/jupyter-kernel-gap/issues/36 |
comment:15
Replying to @dimpase:
True, but I don't see why that means that we shouldn't merge it in Sage. There are several abandoned projects in Sage already, even as standard packages. |
comment:16
+1. What would be bad would be to introduce the feature, and then later have to remove it because it does not work anymore. Here upstream is very motivated by the feature, and has gone a long way toward the newer implementation with libgap being planned for next GAP release. So we can expect the new implementation to come along in the coming months. And for now the current implementation works and is useful. I'll double check with Markus that he is ok to expose the current implementation. |
comment:17
Markus's answer: absolutely, its available, it should be used. I'm not keen to spend a lot of time on maintenance, since I'd rather get the new kernel to work. |
comment:18
So please review this ticket then :-) |
Reviewer: Dima Pasechnik |
Changed branch from u/jdemeyer/add_jupyter_gap_wrapper_package to |
This comment has been minimized.
This comment has been minimized.
Changed commit from |
comment:21
Instruction of how to install the optional package:
|
This package provides the GAP kernel for the Jupyter notebook,
making it available from the Sage's Jupyter notebook .
The source repository is at
Demo notebook
Tarball
Note. This is an optional package. To make it available to an existing Sage installation,
run the following command in a terminal:
Upstream: Reported upstream. Developers acknowledge bug.
CC: @nthiery @dimpase
Component: packages: optional
Author: Jeroen Demeyer
Branch:
33e27fd
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/21416
The text was updated successfully, but these errors were encountered: