Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement conversion MPC -> PARI #21434

Closed
jdemeyer opened this issue Sep 6, 2016 · 12 comments
Closed

Implement conversion MPC -> PARI #21434

jdemeyer opened this issue Sep 6, 2016 · 12 comments
Labels
c: interfaces p: major / 3 t: enhancement
Milestone
sage-7.4

Comments

@jdemeyer
Copy link

jdemeyer commented Sep 6, 2016

CC: @defeo

Component: interfaces

Author: Jeroen Demeyer

Branch/Commit: 0be2020

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/21434
@jdemeyer jdemeyer added this to the sage-7.4 milestone Sep 6, 2016
@jdemeyer
Copy link
Author

jdemeyer commented Sep 6, 2016

Branch: u/jdemeyer/implement_conversion_mpc____pari

@jdemeyer
Copy link
Author

jdemeyer commented Sep 6, 2016

Commit: 9c82df5

@jdemeyer
Copy link
Author

jdemeyer commented Sep 6, 2016

New commits:

9c82df5Implement conversion MPC -> PARI

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

40aaa80Implement conversion MPC -> PARI

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2016

Changed commit from 9c82df5 to 40aaa80

@tscrim
Copy link
Collaborator

tscrim commented Sep 6, 2016

comment:4

Instead of pari(0), wouldn't it be better to use pari.PARI_ZERO? Otherwise LGTM.

@jdemeyer
Copy link
Author

jdemeyer commented Sep 6, 2016

comment:5

Obviously...

sage: timeit('pari(0r)', number=10^5, repeat=20)
100000 loops, best of 20: 510 ns per loop
sage: timeit('pari.PARI_ZERO', number=10^5, repeat=20)
100000 loops, best of 20: 49.6 ns per loop

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2016

Changed commit from 40aaa80 to 0be2020

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 6, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0be2020Implement conversion MPC -> PARI

@tscrim
Copy link
Collaborator

tscrim commented Sep 6, 2016

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Sep 6, 2016

comment:7

Thanks.

@vbraun
Copy link
Member

vbraun commented Sep 8, 2016

Changed branch from u/jdemeyer/implement_conversion_mpc____pari to 0be2020

@vbraun vbraun closed this as completed in d7f5eba Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.4
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer