Integer log is puzzled by Python int argument

[rwst]

sage: ZZ(8).log(int(2))
log(8)/log(2)

Depends on #21517

Component: numerical

Author: Ralf Stephan

Branch/Commit: ab830ba

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/21518

[rwst]

Branch: u/rws/integer_log_is_puzzled_by_python_int_argument

[rwst]

Dependencies: #21517

[rwst]

New commits:

de1acfa	21517: handle ZZ.log(1/n)
3ce2cd2	21518: accept Python ints as log base to ZZ.log

[rwst]

Commit: 3ce2cd2

[rwst]

Author: Ralf Stephan

[tscrim]

comment:3

Why not if type(m) == int:? Or perhaps, a more robust if m in ZZ: (or try: m = Integer(m))?

[tscrim]

Reviewer: Travis Scrimshaw

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

79a5a4a

21518: improve code

[sagetrac-git]

Changed commit from 3ce2cd2 to 79a5a4a

[sagetrac-git]

Changed commit from 79a5a4a to 33a0de3

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4aba8a9	21517: avoid duplicate computations
33a0de3	Merge branch 'u/rws/log_of_integer_to_base_1_n_can_have_exact_numeric_results' of trac.sagemath.org:sage into t/21518/integer_log_is_puzzled_by_python_int_argument

[tscrim]

comment:7

Why is the if m is None: case in the try block? Could we just test that first?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6e250f0

21518: reorder some lines

[sagetrac-git]

Changed commit from 33a0de3 to 6e250f0

[tscrim]

comment:9

One last thing, the if m in None: block is 1 over indented. Once you make this change, you can set a positive review on my behalf.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

ab830ba

21518: cosmetics

[sagetrac-git]

Changed commit from 6e250f0 to ab830ba

[rwst]

comment:11

Thanks for the review.

[vbraun]

Changed branch from u/rws/integer_log_is_puzzled_by_python_int_argument to ab830ba