IPython 5 / python-prompt-toolkit not usable on dumb terminals (inside Emacs comint)

[mkoeppe]

This ticket tracks on our side the following issues:

• IPython: ​If environment variable TERM is set to "dumb", don't use escape sequences ipython/ipython#9886
• python-prompt-toolkit: If environment variable TERM is set to "dumb", don't use escape sequences prompt-toolkit/python-prompt-toolkit#390

These issues cause sage-mode to fail (#21227).

Depends on #28197

Upstream: Reported upstream. Developers acknowledge bug.

CC: darthandrus@gmail.com @johanrosenkilde @vbraun @dimpase @kiwifb @EmmanuelCharpentier @sagetrac-stakemori @novoselt @jhpalmieri

Component: user interface

Issue created by migration from https://trac.sagemath.org/ticket/21558

[mkoeppe]

Changed upstream from Reported upstream. No feedback yet. to Reported upstream. Developers acknowledge bug.

[mkoeppe]

comment:2

Upstream is now working on a fix: prompt-toolkit/python-prompt-toolkit#1035

[mkoeppe]

comment:3

A fix has been merged into prompt-toolkit master.

[mkoeppe]

comment:4

It appears to be in the 3.0.3 release. The 3.x releases are python3 only. Sage currently uses IPython 5, which is using prompt-toolkit 1.x.

[mkoeppe]

Dependencies: #28197

[mkoeppe]

comment:5

After #28197, we have prompt-toolkit 3.0.3. Something has changed, but TERM=dumb ./sage now has strange echo behavior.

This is not very important for us any more after #25363 (--simple-prompt), noting that the shortcomings of simple-prompt pointed out in prompt-toolkit/python-prompt-toolkit#390 (comment) have been fixed.