Implementation of Littlewood-Richardson tableaux #21615

anneschilling · 2016-09-30T16:46:36Z

This patch implements a new class for Littlewood-Richardson tableaux.

CC: @MariaMonks @sagetrac-j-levinson @tscrim

Component: combinatorics

Author: Maria Gillespie, Anne Schilling, Jake Levinson

Branch/Commit: 40414a3

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/21615

The text was updated successfully, but these errors were encountered:

anneschilling · 2016-10-06T04:47:57Z

comment:2

This is a first implementation of LR tableaux. Things to improve:

allow for skew LR tableaux
improve the iterator (it is currently a dumb iterator selecting semistandard tableaux that are LR with respect to a given sequence of weights)

New commits:

`ec8d39c`	`first implementation of Littlewood-Richardson tableaux`

anneschilling · 2016-10-06T04:47:57Z

Commit: ec8d39c

anneschilling · 2016-10-06T04:47:57Z

Author: Maria Gillespie, Anne Schilling

anneschilling · 2016-10-06T04:47:57Z

Branch: u/aschilling/LR-tableaux-21615

tscrim · 2016-10-06T14:15:44Z

comment:3

Hey Maria and Anne,

I've taken a look over this and there are a few polishing things that need to be done.

You should have documentation for each of the classes. This is important both for locality of documentation and so LittlewoodRichardsonTableau? does not show the __init__ documentation. You can just put the INPUT: block at the class level doc as well.
For error messages, they are typically not considered complete sentences, and should not start with a capital letter or end with punctuation.
In the documentation, double backticks is code formatting, single is latex. So you should change, e.g., `self` to ``self``.
For inputs, we are trying to standardize them to the form
```
- ``arg`` -- (optional) some explanation
```
(note, also no punctuation).

It also seems like what you want LR tableaux to inherit from is SemistandardTableaux_shape_weight. This way you can just use the base class iterator instead of creating a new parent. Actually, better yet, you could just call for t in symmetrica.kostka_tab(self.shape, self.weight):. As of right now, your iterator does not create instances of LittlewoodRichardsonTableau:

sage: from sage.combinat.lr_tableau import LittlewoodRichardsonTableaux
sage: LR = LittlewoodRichardsonTableaux([3,2,1],[[2,1],[2,1]])
sage: LR[0]
[[1, 1, 3], [2, 3], [4]]
sage: type(_)
<class 'sage.combinat.tableau.SemistandardTableaux_shape_weight_with_category.element_class'>

tscrim · 2016-10-06T14:15:44Z

Reviewer: Travis Scrimshaw

sagetrac-git · 2016-10-07T04:49:04Z

Changed commit from ec8d39c to d126923

sagetrac-git · 2016-10-07T04:49:04Z

Branch pushed to git repo; I updated commit sha1. New commits:

`d126923`	`fixed most of Travis' comments`

anneschilling · 2016-10-07T04:51:45Z

comment:5

Hi Travis,

Thanks for your comments. I fixed most of the issues you mention.

It also seems like what you want LR tableaux to inherit from is SemistandardTableaux_shape_weight. This way you can just use the base class iterator instead of creating a new parent. Actually, better yet, you could just call for t in symmetrica.kostka_tab(self.shape, self.weight):.

This suggestion does not seem to work. We are anyway planning to implement a smarter iterator, so it is probably not worth it to call symmetrica.

Anne

tscrim · 2016-10-15T22:23:21Z

Changed branch from u/aschilling/LR-tableaux-21615 to public/combinat/LR_tableaux-21615

tscrim · 2016-10-15T22:23:21Z

Changed commit from d126923 to 3490837

tscrim · 2016-10-15T22:23:21Z

comment:6

I reworked things around a bit so that the iterator doesn't create intermediate instances of SemistandardTableau. I also added a __contains__ method and subsequently reworked the check to avoid duplication. I also did a few other doc and little things, including lazily importing the LR tableaux into the global namespace. Let me know if you want to do the iterator on this ticket or on a followup.

New commits:

`7e45dc9`	`Merge branch 'u/aschilling/LR-tableaux-21615' of git://trac.sagemath.org/sage into public/combinat/RC_tableaux-21615`
`3490837`	`Some reviewer changes and fixes.`

anneschilling · 2016-10-17T06:10:44Z

comment:7

There seems to be a doctest failure now:

sage -t finite_word.py
**********************************************************************
File "finite_word.py", line 606, in sage.combinat.words.finite_word.FiniteWord_class.is_yamanouchi
Failed example:
    w.is_yamanouchi(n=3)
Exception raised:
    Traceback (most recent call last):
      File "/Applications/sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 498, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/Applications/sage/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 861, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.combinat.words.finite_word.FiniteWord_class.is_yamanouchi[5]>", line 1, in <module>
        w.is_yamanouchi(n=Integer(3))
      File "/Applications/sage/local/lib/python2.7/site-packages/sage/combinat/words/finite_word.py", line 619, in is_yamanouchi
        w = Word(self, alphabet = range(1,n+1))
      File "/Applications/sage/local/lib/python2.7/site-packages/sage/combinat/words/word.py", line 208, in Word
        parent = Words(alphabet)
      File "/Applications/sage/local/lib/python2.7/site-packages/sage/combinat/words/words.py", line 101, in Words
        return FiniteOrInfiniteWords(alphabet)
      File "/Applications/sage/local/lib/python2.7/site-packages/sage/combinat/words/words.py", line 1722, in __init__
        AbstractLanguage.__init__(self, alphabet)
      File "/Applications/sage/local/lib/python2.7/site-packages/sage/combinat/words/words.py", line 149, in __init__
        alphabet = build_alphabet(alphabet)
      File "/Applications/sage/local/lib/python2.7/site-packages/sage/combinat/words/alphabet.py", line 268, in build_alphabet
        raise ValueError("unable to construct an alphabet from the given parameters")
    ValueError: unable to construct an alphabet from the given parameters
**********************************************************************
1 item had failures:
   1 of  12 in sage.combinat.words.finite_word.FiniteWord_class.is_yamanouchi
    [1270 tests, 1 failure, 3.31 s]

I do not recall that it was there before, but I could be mistaken!

tscrim · 2016-10-17T12:34:39Z

comment:8

This comes from the fact that I used a new beta of sage, where words are now using Python3 style range. It is not a list anymore, so the simplest fix is to wrap it in a list.

sagetrac-git · 2016-10-17T14:03:11Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ecf10ef`	`Some changes to finite word, including Python3 compatibility.`

sagetrac-git · 2016-10-17T14:03:11Z

Changed commit from 3490837 to ecf10ef

anneschilling · 2016-10-19T23:20:48Z

comment:10

I think this can go in now. We can reimplement the iterator later!

tscrim · 2016-10-20T05:32:17Z

comment:11

Then if you're happy with my latest changes, then you can set a positive review.

sagetrac-git · 2016-10-24T04:41:48Z

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

`9c67f19`	`added an implementation of LR tableaux using Buch's lrcalc`

sagetrac-git · 2016-10-24T04:41:48Z

Changed commit from ecf10ef to 9c67f19

sagetrac-j-levinson · 2016-10-24T04:51:33Z

comment:14

Hi all,

I wrote an iterator, LRtabs_multi, that calls Anders Buch's fast lrcalc code (which can compute LR tableaux with specified skew shape). The tableaux we want can be found using a sequence of lrcalc calls.

I didn't rewrite the current __iter__ method because this new one is slightly more general (it can compute skew tableaux rather than straight shape tableaux).

-Jake

sagetrac-git · 2016-10-26T12:05:10Z

Changed commit from 9c67f19 to 1d3fe7c

sagetrac-git · 2016-10-26T12:05:10Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1a8576a`	`Merge branch 'develop' into public/combinat/LR_tableaux-21615`
`1a222e9`	`Merge branch 'public/combinat/LR_tableaux-21615' of git://trac.sagemath.org/sage into public/combinat/LR_tableaux-21615`
`90dc8e3`	`Merge branch 'public/combinat/LR_tableaux-21615' of git://trac.sagemath.org/sage into public/combinat/LR_tableaux-21615`
`8c63ec6`	`Merge branch 'develop' into public/combinat/LR_tableaux-21615`
`a5666ba`	`new iterator along Jake's ideas`
`1d3fe7c`	`added Jake's name to authors`

anneschilling · 2016-10-26T12:26:16Z

comment:16

Hi Jake and all,

Thank you for your improvements. I rewrote the __iter__ method that uses lrskew and your method _tableauJoin (which I renamed _tableau_join). It seems shorter than what you had as it does not need standardization or destandardization. See what you think. It should be relatively easy to upgrade the whole class to allow for SkewTableaux as well. But perhaps we can leave that for another
ticket?

Best,

Anne

sagetrac-git · 2016-10-30T22:53:35Z

Changed commit from 1d3fe7c to 40414a3

sagetrac-git · 2016-10-30T22:53:35Z

Branch pushed to git repo; I updated commit sha1. New commits:

`40414a3`	`Some last little tweaks.`

tscrim · 2016-10-30T22:56:18Z

Changed author from Maria Gillespie, Anne Schilling to Maria Gillespie, Anne Schilling, Jake Levinson

tscrim · 2016-10-30T22:56:18Z

comment:20

I made a few little more tweaks. If my changes look good, you can set it back to a positive review.

anneschilling · 2016-11-01T07:02:01Z

comment:21

Thanks for the review!

vbraun · 2016-11-07T18:27:47Z

Changed branch from public/combinat/LR_tableaux-21615 to 40414a3

anneschilling added this to the sage-7.4 milestone Sep 30, 2016

anneschilling added c: combinatorics labels Sep 30, 2016

This comment has been minimized.

Sign in to view

anneschilling added the s: needs review label Oct 6, 2016

tscrim added s: needs work and removed s: needs review labels Oct 6, 2016

anneschilling added s: needs review and removed s: needs work labels Oct 19, 2016

anneschilling added s: positive review and removed s: needs review labels Oct 20, 2016

sagetrac-git mannequin added s: needs review and removed s: positive review labels Oct 24, 2016

dimpase modified the milestones: sage-7.4, sage-7.5 Oct 26, 2016

vbraun modified the milestones: sage-7.5, sage-7.6 Oct 29, 2016

tscrim modified the milestones: sage-7.6, sage-7.5 Oct 30, 2016

anneschilling added s: positive review and removed s: needs review labels Nov 1, 2016

vbraun removed the s: positive review label Nov 7, 2016

vbraun closed this as completed in b0c78a6 Nov 7, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of Littlewood-Richardson tableaux #21615

Implementation of Littlewood-Richardson tableaux #21615

anneschilling commented Sep 30, 2016

anneschilling commented Oct 6, 2016

anneschilling commented Oct 6, 2016

anneschilling commented Oct 6, 2016

This comment has been minimized.

anneschilling commented Oct 6, 2016

tscrim commented Oct 6, 2016

tscrim commented Oct 6, 2016

sagetrac-git mannequin commented Oct 7, 2016

sagetrac-git mannequin commented Oct 7, 2016

anneschilling commented Oct 7, 2016

tscrim commented Oct 15, 2016

tscrim commented Oct 15, 2016

tscrim commented Oct 15, 2016

anneschilling commented Oct 17, 2016

tscrim commented Oct 17, 2016

sagetrac-git mannequin commented Oct 17, 2016

sagetrac-git mannequin commented Oct 17, 2016

anneschilling commented Oct 19, 2016

tscrim commented Oct 20, 2016

sagetrac-git mannequin commented Oct 24, 2016

sagetrac-git mannequin commented Oct 24, 2016

sagetrac-j-levinson mannequin commented Oct 24, 2016

sagetrac-git mannequin commented Oct 26, 2016

sagetrac-git mannequin commented Oct 26, 2016

anneschilling commented Oct 26, 2016

sagetrac-git mannequin commented Oct 30, 2016

sagetrac-git mannequin commented Oct 30, 2016

tscrim commented Oct 30, 2016

tscrim commented Oct 30, 2016

anneschilling commented Nov 1, 2016

vbraun commented Nov 7, 2016

Implementation of Littlewood-Richardson tableaux #21615

Implementation of Littlewood-Richardson tableaux #21615

Comments

anneschilling commented Sep 30, 2016

anneschilling commented Oct 6, 2016

anneschilling commented Oct 6, 2016

anneschilling commented Oct 6, 2016

This comment has been minimized.

anneschilling commented Oct 6, 2016

tscrim commented Oct 6, 2016

tscrim commented Oct 6, 2016

sagetrac-git mannequin commented Oct 7, 2016

sagetrac-git mannequin commented Oct 7, 2016

anneschilling commented Oct 7, 2016

tscrim commented Oct 15, 2016

tscrim commented Oct 15, 2016

tscrim commented Oct 15, 2016

anneschilling commented Oct 17, 2016

tscrim commented Oct 17, 2016

sagetrac-git mannequin commented Oct 17, 2016

sagetrac-git mannequin commented Oct 17, 2016

anneschilling commented Oct 19, 2016

tscrim commented Oct 20, 2016

sagetrac-git mannequin commented Oct 24, 2016

sagetrac-git mannequin commented Oct 24, 2016

sagetrac-j-levinson mannequin commented Oct 24, 2016

sagetrac-git mannequin commented Oct 26, 2016

sagetrac-git mannequin commented Oct 26, 2016

anneschilling commented Oct 26, 2016

sagetrac-git mannequin commented Oct 30, 2016

sagetrac-git mannequin commented Oct 30, 2016

tscrim commented Oct 30, 2016

tscrim commented Oct 30, 2016

anneschilling commented Nov 1, 2016

vbraun commented Nov 7, 2016