Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctest continuation marked / rings, misc #21674

Closed
jm58660 mannequin opened this issue Oct 10, 2016 · 8 comments
Closed

Doctest continuation marked / rings, misc #21674

jm58660 mannequin opened this issue Oct 10, 2016 · 8 comments
Labels
c: documentation p: minor / 4 t: enhancement
Milestone
sage-7.5

Comments

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Oct 10, 2016

Every grepping of source code is easier if there is just one way to do something. Also some user might wonder if there is a difference between ... and ....:. Hence I suggest mass change from old-style doctest continuation lines.

This part does that in rings and misc folder.

Done by

find src/sage/rings src/sage/misc -name '*.py' -or -name '*.pyx' | xargs perl -e 's|^( *)\.\.\.  |\1....:|g;' -p -i.bak

CC: @tscrim

Component: documentation

Author: Jori Mäntysalo

Branch/Commit: 14ac865

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/21674
@jm58660 jm58660 mannequin added this to the sage-7.5 milestone Oct 10, 2016
@jm58660 jm58660 mannequin added c: documentation labels Oct 10, 2016
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Oct 10, 2016

Branch: u/jmantysalo/linecont-rings-misc

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Oct 10, 2016

comment:2

To be tested, not ready for review.

New commits:

14ac865Doctest continuation / rings, misc.

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Oct 10, 2016

Commit: 14ac865

@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Oct 10, 2016

comment:3

Tests passed on my Linux.

@jm58660 jm58660 mannequin added the s: needs review label Oct 10, 2016
@jm58660
Copy link
Mannequin Author

jm58660 mannequin commented Oct 14, 2016

comment:4

Travis? Nothing special in this.

@tscrim
Copy link
Collaborator

tscrim commented Oct 15, 2016

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 15, 2016

comment:5

Now to hope for no conflicts.

@vbraun
Copy link
Member

vbraun commented Oct 29, 2016

Changed branch from u/jmantysalo/linecont-rings-misc to 14ac865

@vbraun vbraun closed this as completed in 27fa09d Oct 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-7.5
Development

No branches or pull requests
2 participants
@vbraun @tscrim