When building Python on OS X, test whether _scproxy can be imported successfully.

[jhpalmieri]

On OS X 10.12, and also with some earlier versions of OS X, we have had problems with the Sage build because Python claimed to build correctly even though the module _scproxy did not actually build. So let's test to make sure.

Component: packages: standard

Author: John Palmieri

Branch/Commit: 791ed00

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/21685

[jhpalmieri]

Branch: u/jhpalmieri/test_scproxy

[jhpalmieri]

New commits:

3fc278e

When building Python on OS X, test whether _scproxy can be imported successfully.

[jhpalmieri]

Commit: 3fc278e

[kiwifb]

comment:3

Is there a way to test before installing python? Once python is installed you are screwed, so it should happen before, or possibly start the clean up.

[jhpalmieri]

comment:4

I don't know enough about the Python build process to know how to test before it is installed. We can uninstall if it fails, though.

[kiwifb]

comment:5

I'll look to see if there is an easy way to figure out before installing.

[kiwifb]

comment:6

From the "src" folder

find build -name _scproxy.so
build/lib.macosx-10.9-x86_64-2.7/_scproxy.so

So we should abort if find returns nothing before installing I'd say.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2c4f43c

trac 21685: uninstall the Python if _scproxy does not import.

[sagetrac-git]

Changed commit from 3fc278e to 2c4f43c

[sagetrac-git]

Changed commit from 2c4f43c to 791ed00

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

791ed00

trac 21685: detect whether _scproxy has built before installing.

[jhpalmieri]

comment:9

Great, that's better than what I was doing. I'm wary of deleting things, so I've removed that part of my changes. I think we can still test for _scproxy at the end, just in case.

[jhpalmieri]

comment:10

I just tested this on OS X 10.12 with and without my branch from #21567 (so with Python succeeding and failing to build _scproxy) and it seems to detect this correctly.

[kiwifb]

comment:11

Looks good to me.

[kiwifb]

Reviewer: François Bissey

[vbraun]

Changed branch from u/jhpalmieri/test_scproxy to 791ed00