Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make xz a standard package #21744

Closed
EmmanuelCharpentier mannequin opened this issue Oct 23, 2016 · 10 comments
Closed

make xz a standard package #21744

EmmanuelCharpentier mannequin opened this issue Oct 23, 2016 · 10 comments

Comments

@EmmanuelCharpentier
Copy link
Mannequin

EmmanuelCharpentier mannequin commented Oct 23, 2016

Rationale :

  • R is a standard package.
  • It now depends on liblzma (see Upgrade R to 3.3.3 #20523).
  • liblzma is available through xz.
  • Therefore R depends on xz.
  • A standard package cannot depend on an optional package

Therefore xz has to become standard. QED.

Trivial patch to follow shortly (Real_World(TM) adjuvante)...

Component: packages: optional

Author: Emmanuel Charpentier

Branch/Commit: b4da321

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/21744

@EmmanuelCharpentier EmmanuelCharpentier mannequin added this to the sage-7.5 milestone Oct 23, 2016
@mkoeppe mkoeppe changed the title make zx a standard package make xz a standard package Oct 23, 2016
@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Oct 23, 2016

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Oct 23, 2016

comment:3

Passes ptestlong with two transient errors, as usual :

----------------------------------------------------------------------
sage -t --long --warn-long 99.8 src/sage/homology/simplicial_complex.py  # 1 doctest failed
sage -t --long --warn-long 99.8 src/sage/categories/sets_cat.py  # Bad exit: 2
----------------------------------------------------------------------

which both pâss standalone with no error.

==> needs_review


New commits:

b4da321One-word patch.

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Oct 23, 2016

Author: Emmanuel Charpentier

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Oct 23, 2016

Commit: b4da321

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Oct 23, 2016

comment:4

Replying to @mkoeppe:

Thanks ! I'm a bit of a distracted man...

@tscrim
Copy link
Collaborator

tscrim commented Oct 23, 2016

comment:5

A notice about this should be posted to sage-devel, but I am in favor of this change.

@EmmanuelCharpentier
Copy link
Mannequin Author

EmmanuelCharpentier mannequin commented Oct 23, 2016

comment:6

Replying to @tscrim:

A notice about this should be posted to sage-devel, but I am in favor of this change.

Done here. Thanks for the reminder...

@mkoeppe
Copy link
Member

mkoeppe commented Jan 11, 2017

comment:7

The outcome of the poll on sage-devel seems to have been positive, so I'm setting this to positive review.
(I'd like to use xz for a CGAL package, #18197.)

@mkoeppe
Copy link
Member

mkoeppe commented Jan 11, 2017

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Jan 18, 2017

Changed branch from u/charpent/make_zx_a_standard_package to b4da321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants