From "colour" to "color"; i.e. to US english

[jm58660]

This patch will change some colours to colors.

The real question is larger: shall we add "Use US english" to the developer manual? I think that we should. (I have no prefence, but US english is currently more used.)

CC: @jdemeyer @tscrim @fchapoton

Component: documentation

Author: Jori Mäntysalo

Branch/Commit: u/jmantysalo/color-colour @ c346d2c

Reviewer: Peter Bruin, Frédéric Chapoton, Peleg Michaeli

Issue created by migration from https://trac.sagemath.org/ticket/21752

[jm58660]

Branch: u/jmantysalo/color-colour

[jm58660]

Commit: c346d2c

[jm58660]

New commits:

c346d2c

Change colours to colors.

[jm58660]

comment:3

Got no interest about US/GB -issue.

So I just mark this colour->color as needs_review. Please review, either to milestone sage-7.5 or to milestone wontfix.

[pjbruin]

comment:4

I disagree with enforcing a particular spelling. Both are perfectly acceptable, and permitting both has absolutely no effect on readability. I just expect people who use one variant to get annoyed by others "correcting" their spelling to the others' preferred variant.

[fchapoton]

comment:5

Replying to @pjbruin:

I disagree with enforcing a particular spelling. Both are perfectly acceptable, and permitting both has absolutely no effect on readability. I just expect people who use one variant to get annoyed by others "correcting" their spelling to the others' preferred variant.

Same opinion. I vote for duplicate/invalid.

[jm58660]

comment:6

OK, but what you think about

class Color(object):
     def __int__(self):
         """
         Return the integer representation of this colour.

or like? Fortunately we have only one form used as keyword or function name. I suppose that you wouldn't like them to have different spelling.

(You can be sure that I have no personal preference of which one to use. My native language is quite far from english.)

[pelegm]

comment:7

I vote for invalid.

I think that code (methods, functions, classes) should all follow US English (this is just far too common in CASs so far; and it should be consistent), so for example g.find_colors together with g.colourful should definitely be unacceptable, but docstrings with GB spelling, even if the function name is in US spelling, is fine with me.

(It is perhaps not super-aesthetic; but I guess we can live with it)

[jm58660]

comment:8

OK.

[pjbruin]

Reviewer: Peter Bruin, Frédéric Chapoton, Peleg Michaeli