Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in the Chow ring of a matroid #21761

Closed
sagetrac-jwiltshiregordon mannequin opened this issue Oct 24, 2016 · 8 comments
Closed

Bug in the Chow ring of a matroid #21761

sagetrac-jwiltshiregordon mannequin opened this issue Oct 24, 2016 · 8 comments

Comments

@sagetrac-jwiltshiregordon
Copy link
Mannequin

The Chow ring of a matroid was implemented in ticket #19587. However, there is a small error in the set of quadratic relations. The line

Q = [gens[i] * gens[i+j+1] for i,F in enumerate(flats)
     for j,G in enumerate(flats[i+1:]) if F < G or G < F]

should read

Q = [gens[i] * gens[i+j+1] for i,F in enumerate(flats)
     for j,G in enumerate(flats[i+1:]) if not (F < G or G < F)]

since the quadratic relations are imposed when two flats are incomparable.

CC: @tscrim

Component: matroid theory

Author: John Wiltshire-Gordon

Branch/Commit: 2773de6

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/21761

@tscrim

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Oct 24, 2016

Commit: 26d4124

@tscrim
Copy link
Collaborator

tscrim commented Oct 24, 2016

Author: John Wiltshire-Gordon

@tscrim
Copy link
Collaborator

tscrim commented Oct 24, 2016

@tscrim
Copy link
Collaborator

tscrim commented Oct 24, 2016

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 24, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

2773de6Fixing the quadratic ideal of the Chow ring of a matroid.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 24, 2016

Changed commit from 26d4124 to 2773de6

@vbraun
Copy link
Member

vbraun commented Oct 31, 2016

Changed branch from public/matroids/fix_chow_ring_ideal-21761 to 2773de6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants