Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debianized jmol spkg #2177

Closed
timabbott opened this issue Feb 16, 2008 · 5 comments
Closed

debianized jmol spkg #2177

timabbott opened this issue Feb 16, 2008 · 5 comments

Comments

@timabbott
Copy link
Contributor

For some reason the jmol directory shipped with SAGE does not contain the doc/ directory, which causes it to fail to build on Debian (or anything else, I'm pretty sure). The current spkg-install script just copies the pre-built jmol jars, but presumably it'd be better to build our own (certainly Debian will want me to do this).

The doc/ directory is not large, so I'm not sure why it is missing, so I've obtained a copy of the doc directory from the jmol-11.5.2 upstream.

I also move the "jmol/" directory to "src/" for compliance with our new spkg format standards.

I'll post a new SPKG later tonight.

Component: debian-package

Issue created by migration from https://trac.sagemath.org/ticket/2177

@williamstein
Copy link
Contributor

comment:1

The current spkg-install script just copies the pre-built jmol
jars, but presumably it'd be better to build our own (certainly
Debian will want me to do this).

We also VERY MUCH want easy-to-build-from source java code
for this package. Note that there is a jmol optional src package
here:

http://sagemath.org/packages/optional/

@timabbott
Copy link
Contributor Author

comment:2

JMol itself builds from source just fine if you install Sun Java (currently in Debian non-free) and ant. It looks like the optional spkg has a bunch of dependencies that are shipped with the jmol spkg; so I guess that's what we're missing?

The new spkg with Debian build support is available here:
http://sage.math.washington.edu/home/tabbott/jmol-11.5.2.p1.spkg

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Feb 16, 2008

comment:3

I added a changelog entry to SPKG.txt, otherwise positive review.

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Feb 16, 2008

comment:4

Merged in Sage 2.10.2.alpha0

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Feb 16, 2008
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Feb 16, 2008

comment:5

Arrg, it was actually merged in Sage 2.10.2.alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants