Fix indents and trailing whitespace

[jdemeyer]

In all scripts: Use spaces, not a mixture of spaces and TABs to indent. Also remove all trailing whitespace.

CC: @embray @dimpase @mkoeppe

Component: scripts

Author: Jeroen Demeyer

Branch/Commit: b7d7a71

Reviewer: Matthias Koeppe, John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/21792

[jdemeyer]

Branch: u/jdemeyer/fix_indents_in_sage_spkg

[jdemeyer]

Commit: 3e9aee3

[jdemeyer]

comment:5

This is a totally trivial ticket. To avoid merge conflicts, a quick review would come in handy.

---

New commits:

3e9aee3

Fix indents and trailing spaces in scripts

[dimpase]

comment:7

Have you used a script to do this? If so, can we have a look at it?

[jdemeyer]

comment:8

It was a very trivial sed script, replacing every TAB by 8 spaces and deleting all trailing spaces. I had to undo a few cases where the TABs were in Makefiles or where the TABs were not leading space.

[mkoeppe]

comment:9

Perhaps the whitespace policy should be documented in our developer manual.

[mkoeppe]

comment:10

And we should have a .dir-locals.el and its equivalent (if any) for vim users.
https://www.gnu.org/software/emacs/manual/html_node/emacs/Directory-Variables.html

[mkoeppe]

comment:11

I've created ticket #21793 for that.

[mkoeppe]

Reviewer: Matthias Koeppe

[jhpalmieri]

comment:13

On my OS X machine, the change to ecm/spkg-install leads to

./spkg-install: line 293: syntax error: unexpected end of file

Undo the change and it works fine. (The - in cat >foo.c <<-"EOF" means to strip leading tabs, and << is looking for just "EOF" all by itself, so the line EOF needs to be indented strictly by tabs or not at all.)

[sagetrac-git]

Changed commit from 3e9aee3 to b7d7a71

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b7d7a71

Don't use <<- here documents

[jdemeyer]

comment:16

I think it's confusing to require TABs, so I used an ordinary here document with <<.

[jhpalmieri]

Changed reviewer from Matthias Koeppe to Matthias Koeppe, John Palmieri

[jhpalmieri]

comment:17

Okay, looks good.

[vbraun]

Changed branch from u/jdemeyer/fix_indents_in_sage_spkg to b7d7a71