Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unnecessary flint include directories #21803

Closed
mkoeppe opened this issue Nov 3, 2016 · 10 comments
Closed

Clean up unnecessary flint include directories #21803

mkoeppe opened this issue Nov 3, 2016 · 10 comments
Labels
c: cython p: major / 3 t: enhancement
Milestone
sage-7.5

Comments

@mkoeppe
Copy link
Member

mkoeppe commented Nov 3, 2016

There is no reason to add $SAGE_LOCAL/include/flint as include directory.

CC: @jdemeyer

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 5306746

Reviewer: Marc Mezzarobba, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/21803
@mkoeppe mkoeppe added this to the sage-7.6 milestone Nov 3, 2016
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title env.py, misc/cython.py: Define and use FLINT_INCLUDE_DIR Clean up unnecessary flint include directories Nov 3, 2016
@jdemeyer jdemeyer modified the milestones: sage-7.6, sage-7.5 Nov 3, 2016
@jdemeyer
Copy link

jdemeyer commented Nov 3, 2016

Branch: u/jdemeyer/clean_up_unnecessary_flint_include_directories

@jdemeyer
Copy link

jdemeyer commented Nov 3, 2016

Commit: 5306746

@jdemeyer
Copy link

jdemeyer commented Nov 3, 2016

Author: Jeroen Demeyer

@jdemeyer
Copy link

jdemeyer commented Nov 3, 2016

New commits:

5306746Clean up unnecessary flint include directories

@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@mezzarobba
Copy link
Member

comment:5

Reverting to needs_review because I may be missing something, cf. my question on #21797.

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 3, 2016

comment:6

Actually I had missed something in #21797. It's all good.

@mkoeppe
Copy link
Member Author

mkoeppe commented Nov 3, 2016

Changed reviewer from Marc Mezzarobba to Marc Mezzarobba, Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Nov 8, 2016

Changed branch from u/jdemeyer/clean_up_unnecessary_flint_include_directories to 5306746

@vbraun vbraun closed this as completed in cd11266 Nov 8, 2016
This was referenced Jun 13, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: cython p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.5
Development

No branches or pull requests
4 participants
@vbraun @jdemeyer @mezzarobba @mkoeppe