Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pynac-0.7.0 #21827

Closed
rwst opened this issue Nov 5, 2016 · 16 comments
Closed

Upgrade to pynac-0.7.0 #21827

rwst opened this issue Nov 5, 2016 · 16 comments

Comments

@rwst
Copy link

rwst commented Nov 5, 2016

Included:

https://github.com/pynac/pynac/releases/download/pynac-0.7.0/pynac-0.7.0.tar.bz2

CC: @sagetrac-cmafra

Component: packages: standard

Author: Ralf Stephan, Carlos R. Mafra

Branch: 01455b2

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/21827

@rwst rwst added this to the sage-7.5 milestone Nov 5, 2016
@rwst
Copy link
Author

rwst commented Nov 5, 2016

Branch: u/rws/upgrade_to_pynac_0_7_0

@rwst
Copy link
Author

rwst commented Nov 5, 2016

Author: Ralf Stephan, Carlos R. Mafra

@rwst
Copy link
Author

rwst commented Nov 5, 2016

New commits:

890ce72version/chksum/dependency
20bfd2forthogonal poly improvements
837f07bmisc doctests
a0907b1series changes

@rwst
Copy link
Author

rwst commented Nov 5, 2016

Commit: a0907b1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 7, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

18a725621827: cosmetics

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 7, 2016

Changed commit from a0907b1 to 18a7256

@tscrim
Copy link
Collaborator

tscrim commented Nov 7, 2016

comment:4

Two minor things:

  • Use .. MATH:: as we are trying to be consistent with the dev guide.
  • I think "QQbar" should either be ``QQbar`` or the corresponding latex version.

Once fixed, you can set a positive review on my behalf.

@tscrim
Copy link
Collaborator

tscrim commented Nov 7, 2016

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 7, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

01455b221827: more cosmetics

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 7, 2016

Changed commit from 18a7256 to 01455b2

@rwst
Copy link
Author

rwst commented Nov 7, 2016

comment:7

Thanks for the review.

@kiwifb
Copy link
Member

kiwifb commented Nov 9, 2016

comment:8

I just noticed that you neither do detection of flint in configure or link to the flint library. Meaning that libpynac.so is actually underlinked. This may prove a problem for people using --as-needed in their LDFLAGS and the gold linker. See #20646 for a discussion of a similar situation.

The ticket is good to go for now but I will consider making a PR to solve these issues in 0.7.1.

@rwst
Copy link
Author

rwst commented Nov 9, 2016

comment:9

Thanks for the fix.

@vbraun
Copy link
Member

vbraun commented Nov 9, 2016

Changed branch from u/rws/upgrade_to_pynac_0_7_0 to 01455b2

@rwst

This comment has been minimized.

@rwst
Copy link
Author

rwst commented Nov 10, 2016

Changed commit from 01455b2 to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants