Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the .cython_version format to include all cythonize options #21843

Closed
embray opened this issue Nov 8, 2016 · 8 comments
Closed

Update the .cython_version format to include all cythonize options #21843

embray opened this issue Nov 8, 2016 · 8 comments

Comments

@embray
Copy link
Contributor

embray commented Nov 8, 2016

As discussed beginning here, the current .cython_version stamp does not always accurately reflect all Cython build options which, if changed, should trigger a rebuild of Cython sources.

It would be good to have a more detailed .cython_version that includes all arguments to cythonize() and perhaps all Cython.Compiler.Options.

Although the values of these options are generally simple types, the compiler_directives dict alone makes this data structure complicated enough that an ad hoc format like the one currently used is not justified--instead a json-formatted file should work.

Component: build

Author: Jeroen Demeyer

Branch/Commit: b56b4be

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/21843

@embray embray added this to the sage-7.5 milestone Nov 8, 2016
@embray embray self-assigned this Dec 21, 2016
@jdemeyer
Copy link

@jdemeyer
Copy link

New commits:

b56b4beInclude Cython directives in .cython_version file

@jdemeyer
Copy link

Author: Jeroen Demeyer

@jdemeyer
Copy link

Commit: b56b4be

@embray
Copy link
Contributor Author

embray commented Apr 20, 2017

comment:4

Thanks--straightforward enough.

@tscrim
Copy link
Collaborator

tscrim commented Apr 20, 2017

comment:6

cough cough

@tscrim
Copy link
Collaborator

tscrim commented Apr 20, 2017

Reviewer: Erik Bray

@vbraun
Copy link
Member

vbraun commented Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants