Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of six.moves.range in Cython files (step 3) #21870

Closed
jdemeyer opened this issue Nov 13, 2016 · 12 comments
Closed

Get rid of six.moves.range in Cython files (step 3) #21870

jdemeyer opened this issue Nov 13, 2016 · 12 comments
Labels
c: cython p: blocker / 1 t: bug
Milestone
sage-7.5

Comments

@jdemeyer
Copy link

See also #21476 and #21519.

CC: @fchapoton

Component: cython

Author: Frédéric Chapoton

Branch/Commit: 1d83f0d

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/21870
@jdemeyer jdemeyer added this to the sage-7.5 milestone Nov 13, 2016
@fchapoton
Copy link
Contributor

comment:1

here is a branch, needs to be tested

New commits:

48c4a6etrac 21870 do not import range from six.moves in pyx files at all

@fchapoton
Copy link
Contributor

Commit: 48c4a6e

@fchapoton
Copy link
Contributor

Branch: u/chapoton/21870

@jdemeyer
Copy link
Author

Changed author from Jeroen Demeyer to Frédéric Chapoton

@jdemeyer
Copy link
Author

Reviewer: Jeroen Demeyer

@fchapoton
Copy link
Contributor

comment:3

one failing doctest

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 14, 2016

Changed commit from 48c4a6e to 1d83f0d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 14, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

1d83f0dtracc 21870 fixing doctest

@fchapoton
Copy link
Contributor

comment:5

doctest corrected, back to needs review

@jdemeyer
Copy link
Author

comment:6

Let's wait for the patchbot...

@fchapoton
Copy link
Contributor

comment:7

bot being green, I allow myself to set back to positive

@vbraun
Copy link
Member

vbraun commented Nov 17, 2016

Changed branch from u/chapoton/21870 to 1d83f0d

@vbraun vbraun closed this as completed in 7c84eef Nov 17, 2016
@jdemeyer jdemeyer mentioned this issue Nov 27, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: cython p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-7.5
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @fchapoton