Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3 some __nonzero__ alias for __bool__ #21898

Closed
fchapoton opened this issue Nov 18, 2016 · 12 comments
Closed

py3 some __nonzero__ alias for __bool__ #21898

fchapoton opened this issue Nov 18, 2016 · 12 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-7.5

Comments

@fchapoton
Copy link
Contributor

this time outside of rings folder

part of #16076

CC: @jdemeyer @jm58660 @tscrim

Component: python3

Author: Frédéric Chapoton

Branch/Commit: ae363cf

Reviewer: Jori Mäntysalo

Issue created by migration from https://trac.sagemath.org/ticket/21898
@fchapoton fchapoton added this to the sage-7.5 milestone Nov 18, 2016
@fchapoton
Copy link
Contributor Author

New commits:

d14f0d2another bunch of alias "__nonzero__" for "__bool__" (not in rings folder)

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/21898

@fchapoton
Copy link
Contributor Author

Commit: d14f0d2

@jdemeyer
Copy link

comment:2

Looks good but let's wait for the bot.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 19, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

0fb3b80trac 21898 undo one specific change (abstract_method) for the moment

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 19, 2016

Changed commit from d14f0d2 to 0fb3b80

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 20, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

ae363cftrac 21898 do not require `__bool__` for the moment

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 20, 2016

Changed commit from 0fb3b80 to ae363cf

@fchapoton
Copy link
Contributor Author

comment:5

bot is now green, please review.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Nov 22, 2016

comment:7

OK.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Nov 22, 2016

Reviewer: Jori Mäntysalo

@vbraun
Copy link
Member

vbraun commented Nov 24, 2016

Changed branch from u/chapoton/21898 to ae363cf

@vbraun vbraun closed this as completed in 33c7c40 Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.5
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @fchapoton