make linbox compile with clang and libc++ on Linux and FreeBSD

[dimpase]

Presently linbox assumes that clang and libc++ only come on OSX,
and breaks such a configuration by forcing low-level libstdc++-only features (see #12426, comment 109)

Upstream issue at linbox-team/linbox#46
Pull request for same at linbox-team/linbox#50

cpernet: Pull request has been merged and will be in the next coming release.

Upstream: Fixed upstream, but not in a stable release.

Component: porting

Keywords: clang, libc++

Author: François Bissey

Branch: fc68020

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/21977

[dimpase]

comment:1

reported upstream linbox-team/linbox#46

[dimpase]

Upstream: Reported upstream. No feedback yet.

[kiwifb]

comment:2

I corrected the bit about std::_Bit_reference at the top of field/gf2.h and there is another similar problem at the end of the same file

[linbox-1.4.2] ../../linbox/field/gf2.h:1010:10: fatal error: 'bits/stl_bvector.h' file not found
[linbox-1.4.2] #include <bits/stl_bvector.h>
[linbox-1.4.2]          ^
[linbox-1.4.2] 1 error generated.

The code is

#if __cplusplus >= 201103L
#if defined( __APPLE__) && defined(__clang__)
#include <__bit_reference>
#else
#include <bits/stl_bvector.h>
#endif /* __clang__ */

You shouldn't use headers under bits directly, they are implementation dependent. Is it hard to understand?

[kiwifb]

comment:3

Also I believe it is time to re-enable spkg-check in linbox

[linbox-1.4.2] make[8]: Leaving directory '/home/fbissey/sandbox/git-fork/sage-clang/local/var/tmp/sage/build/linbox-1.4.2/src/tests'
[linbox-1.4.2] make[7]: Leaving directory '/home/fbissey/sandbox/git-fork/sage-clang/local/var/tmp/sage/build/linbox-1.4.2/src/tests'
[linbox-1.4.2] ============================================================================
[linbox-1.4.2] Testsuite summary for LinBox 1.4.2
[linbox-1.4.2] ============================================================================
[linbox-1.4.2] # TOTAL: 15
[linbox-1.4.2] # PASS:  15
[linbox-1.4.2] # SKIP:  0
[linbox-1.4.2] # XFAIL: 0
[linbox-1.4.2] # FAIL:  0
[linbox-1.4.2] # XPASS: 0
[linbox-1.4.2] # ERROR: 0
[linbox-1.4.2] ============================================================================

[kiwifb]

New commits:

fc68020

Include upstream PR50 to deal with C++ conformance spotted using clang. Also re-enable spkg-check.

[kiwifb]

Branch: u/fbissey/linbox-cpp

[kiwifb]

Commit: fc68020

[kiwifb]

Author: François Bissey

[dimpase]

comment:6

I am running ptestlong on freebsd with this branch now.

[dimpase]

Reviewer: Dima Pasechnik

[dimpase]

comment:8

looks good.

[vbraun]

Changed branch from u/fbissey/linbox-cpp to fc68020

[ClementPernet]

Changed commit from fc68020 to none

[ClementPernet]

Changed upstream from Reported upstream. No feedback yet. to Fixed upstream, but not in a stable release.