Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong conversion from algebraic to interval #21979

Closed
videlec opened this issue Nov 26, 2016 · 16 comments
Closed

Wrong conversion from algebraic to interval #21979

videlec opened this issue Nov 26, 2016 · 16 comments

Comments

@videlec
Copy link
Contributor

videlec commented Nov 26, 2016

sage: a = QuadraticField(5).gen()
sage: u = -573147844013817084101/2*a + 1281597540372340914251/2
sage: RealIntervalField(128)(u)
0
sage: RealIntervalField(128)(u).is_zero()
True

There is a related problem coming from the RealLazyField that we do not solve in this ticket

sage: v = RLF(u)
sage: v
0.?e6
sage: v.is_zero()
False
sage: RealIntervalField(128)(v)
0

CC: @sagetrac-tmonteil

Component: basic arithmetic

Author: Vincent Delecroix

Branch/Commit: 0953e11

Reviewer: Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/21979

@videlec videlec added this to the sage-7.5 milestone Nov 26, 2016
@videlec

This comment has been minimized.

@videlec

This comment has been minimized.

@videlec
Copy link
Contributor Author

videlec commented Nov 26, 2016

Commit: cd2828a

@videlec
Copy link
Contributor Author

videlec commented Nov 26, 2016

Author: Vincent Delecroix

@videlec
Copy link
Contributor Author

videlec commented Nov 26, 2016

Branch: u/vdelecroix/21979

@videlec
Copy link
Contributor Author

videlec commented Nov 26, 2016

New commits:

cd2828a21979: fix conversion of algebraic quadratic to real interval

@videlec

This comment has been minimized.

@seblabbe
Copy link
Contributor

comment:6

Problem is fixed. Documentation builds fine. Positive review.

Vincent, do you want to create a ticket for the unsolved problem with RealLazyField ?

@seblabbe
Copy link
Contributor

Reviewer: Sébastien Labbé

@videlec
Copy link
Contributor Author

videlec commented Nov 29, 2016

comment:7

Thanks.

I actually think that we should get rid of RealLazyField in any coercion involving number fields... I opened #21991.

@videlec
Copy link
Contributor Author

videlec commented Nov 29, 2016

comment:8

As patchbots say there is a broken doctest in polynomial_rational_flint.pyx

sage: R.<t> = QQ[]
sage: f = 1 + t/2
sage: f.reverse(I)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 29, 2016

Changed commit from cd2828a to 0953e11

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 29, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

0953e1121979: fix complex quadratic number conversion

@videlec
Copy link
Contributor Author

videlec commented Nov 29, 2016

comment:10

needs review again

@seblabbe
Copy link
Contributor

comment:11

The patchbot says:

----------------------------------------------------------------------
sage -t --long src/sage/modular/modform/ambient.py  # Timed out
----------------------------------------------------------------------

I can not reproduce the problem. All other tests passed. Positive review.

@vbraun
Copy link
Member

vbraun commented Dec 1, 2016

Changed branch from u/vdelecroix/21979 to 0953e11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants