Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complex_embedding on relative number fields is inconsistent with the base field #22008

Open
edgarcosta opened this issue Dec 2, 2016 · 3 comments

Comments

@edgarcosta
Copy link
Member

Here is a minimal example, with a trivial extension.

QQx.<x> = QQ[]
L.<b> = NumberField(x^2 - x - 1)
Ly.<y> = L[];
M.<c> = NumberField(y)
print(L(b).complex_embedding())
print(M(b).complex_embedding())

-0.618033988749895
1.61803398874989

Component: number fields

Keywords: complex_embedding relative

Issue created by migration from https://trac.sagemath.org/ticket/22008

@edgarcosta edgarcosta added this to the sage-7.5 milestone Dec 2, 2016
@sagetrac-bober
Copy link
Mannequin

sagetrac-bober mannequin commented Jul 22, 2017

comment:1
sage: L.absolute_field('z')
Number Field in z with defining polynomial x^2 - x - 1
sage: M.absolute_field('z')
Number Field in z with defining polynomial x^2 + x - 1

@videlec

This comment has been minimized.

@videlec videlec modified the milestones: sage-7.5, sage-9.4 Apr 24, 2021
@videlec
Copy link
Contributor

videlec commented Apr 24, 2021

comment:3

As written in the documentation, the function complex_embedding returns the image of the i-th embedding into the complex numbers (default is i=0). Here is the list

sage: L.complex_embeddings()
[
Ring morphism:
  From: Number Field in b with defining polynomial x^2 - x - 1 with b = 1.618033988749895?
  To:   Complex Field with 53 bits of precision
  Defn: b |--> -0.618033988749895,
Ring morphism:
  From: Number Field in b with defining polynomial x^2 - x - 1 with b = 1.618033988749895?
  To:   Complex Field with 53 bits of precision
  Defn: b |--> 1.61803398874989
]

In particular

  • i=0 is not the complex embedding coming from the coercion embedding
  • for extension fields this list is not sorted according to the embedding of the base

I definitely agree that this is confusing. To my mind, the function b.complex_embedding() is to blame and it is a mistake to have made i=0 the default.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 22, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 May 3, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants