Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document use of SAGE_EXTCODE #22015

Closed
paulmasson mannequin opened this issue Dec 3, 2016 · 7 comments
Closed

Document use of SAGE_EXTCODE #22015

paulmasson mannequin opened this issue Dec 3, 2016 · 7 comments
Labels
c: documentation p: major / 3 t: enhancement
Milestone
sage-7.5

Comments

@paulmasson
Copy link
Mannequin

paulmasson mannequin commented Dec 3, 2016

CC: @kiwifb @sagetrac-tmonteil @EmmanuelCharpentier

Component: documentation

Author: Paul Masson

Branch: bc5e44e

Reviewer: Thierry Monteil

Issue created by migration from https://trac.sagemath.org/ticket/22015
@paulmasson paulmasson mannequin added this to the sage-7.5 milestone Dec 3, 2016
@paulmasson
Copy link
Mannequin Author

paulmasson mannequin commented Dec 3, 2016

Branch: u/paulmasson/22015

@paulmasson
Copy link
Mannequin Author

paulmasson mannequin commented Dec 3, 2016

Commit: bc5e44e

@paulmasson
Copy link
Mannequin Author

paulmasson mannequin commented Dec 3, 2016

comment:2

In response to https://groups.google.com/d/msg/sage-release/__wlsF1jv_Y/lIhAlyQdCQAJ

New commits:

63fc8e1Remove reference to nonexistent directory
bc5e44eAdd SAGE_EXTCODE

@paulmasson paulmasson mannequin added the s: needs review label Dec 3, 2016
@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Dec 3, 2016

Reviewer: Thierry Monteil

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Dec 3, 2016

comment:3

LGTM. Note that adding a space before :: is not common as it will remove the : in the resulting html file. If you change it, it is still OK for me.

@vbraun
Copy link
Member

vbraun commented Dec 5, 2016

Changed branch from u/paulmasson/22015 to bc5e44e

@vbraun vbraun closed this as completed in 99f6548 Dec 5, 2016
@fchapoton
Copy link
Contributor

Changed commit from bc5e44e to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.5
Development

No branches or pull requests
2 participants
@vbraun @fchapoton