Surprising matrix solve error message

[rwst]

This cannot be right, can it?

sage: M = matrix([(3,-1,0,0),(1,1,-2,0),(0,0,0,-3)])
sage: B = matrix(QQ,3,1, [0,0,-1])
sage: M.rows()
[(3, -1, 0, 0), (1, 1, -2, 0), (0, 0, 0, -3)]
sage: B.rows()
[(0), (0), (-1)]
sage: M.nrows()
3
sage: B.nrows()
3
sage: M.solve_left(B)
...
ValueError: number of rows of self must equal number of rows of B

Component: linear algebra

Author: Alina Bucur, Renata Paramastri

Branch/Commit: 358f873

Reviewer: Kiran Kedlaya, Caitlin Lienkaemper, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22073

[sagetrac-alina]

Branch: u/alina/surprising_matrix_solve_error_message

[sagetrac-alina]

New commits:

fa579ae

fixed the error message for solve_left() when the number of columns is not the same on LHS and RHS

[sagetrac-alina]

Author: Alina, Renata

[sagetrac-alina]

Commit: fa579ae

[adeines]

Changed keywords from none to sd90

[sagetrac-clienkaemper]

Reviewer: Caitlin Lienkaemper

[sagetrac-clienkaemper]

Changed keywords from sd90 to none

[sagetrac-clienkaemper]

Changed author from Alina, Renata to none

[tscrim]

comment:5

The author name is now missing (should be in "First Last" format). Also, remove all of your (added) trailing whitespace and break this long line into <80 characters long:

        If the number of columns on the left and right hand sides is different it raises the error message 'number of columns                    of self must equal number of columns of B'

Actually, I would just remove that line altogether as it doesn't add anything practical to the documentation and you have the examples.

[sagetrac-clienkaemper]

Author: Alina Bucur, Renata Paramastri

[sagetrac-clienkaemper]

comment:6

put author info that I accidentally deleted back, now w/ last names

[kedlaya]

comment:7

For the record, all doctests pass on k8s.

[sagetrac-git]

Changed commit from fa579ae to 358f873

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

358f873

removed trailing white spaces and long sentence

[sagetrac-alina]

comment:9

Removed the long sentence completely as tscrim suggested and got rid of the trailing white spaces.

[kedlaya]

Changed reviewer from Caitlin Lienkaemper to Kiran Kedlaya, Caitlin Lienkaemper, Travis Scrimshaw

[kedlaya]

comment:10

Looks good now (and all tests still pass). Positive review.

[vbraun]

Changed branch from u/alina/surprising_matrix_solve_error_message to 358f873