Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom method Group.__contains__() #22092

Closed
pjbruin opened this issue Dec 23, 2016 · 9 comments
Closed

Remove custom method Group.__contains__() #22092

pjbruin opened this issue Dec 23, 2016 · 9 comments
Labels
c: group theory p: major / 3 t: enhancement
Milestone
sage-7.6

Comments

@pjbruin
Copy link
Contributor

pjbruin commented Dec 23, 2016

The method Group.__contains__() behaves in a non-standard way. We remove this method and make two small changes in other methods relying on this non-standard behaviour.

Depends on #22091

Component: group theory

Author: Peter Bruin

Branch/Commit: 742e05c

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22092
@pjbruin pjbruin added this to the sage-7.5 milestone Dec 23, 2016
@pjbruin
Copy link
Contributor Author

pjbruin commented Dec 23, 2016

Branch: u/pbruin/22092-Group_contains

@pjbruin
Copy link
Contributor Author

pjbruin commented Dec 23, 2016

Commit: 956d0be

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5afe081Trac 22128: fix pickling of FinitelyGeneratedMatrixGroup_generic
f368720Trac 22091: allow coercion from matrix groups to matrix rings
80d8901Trac 22092: remove custom method Group.__contains__()

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 3, 2017

Changed commit from 956d0be to 80d8901

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 23, 2017

Changed commit from 80d8901 to 742e05c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 23, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

742e05cTrac 22092: remove custom method Group.__contains__()

@tscrim
Copy link
Collaborator

tscrim commented Jan 24, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jan 24, 2017

comment:4

LGTM.

@tscrim tscrim modified the milestones: sage-7.5, sage-7.6 Jan 24, 2017
@vbraun
Copy link
Member

vbraun commented Jan 28, 2017

Changed branch from u/pbruin/22092-Group_contains to 742e05c

@vbraun vbraun closed this as completed in d6ae2a3 Jan 28, 2017
@pjbruin pjbruin mentioned this issue Jan 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: group theory p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.6
Development

No branches or pull requests
3 participants
@vbraun @tscrim @pjbruin