Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openblas testsuite fails on OSX #22100

Closed
vbraun opened this issue Dec 25, 2016 · 14 comments
Closed

Openblas testsuite fails on OSX #22100

vbraun opened this issue Dec 25, 2016 · 14 comments

Comments

@vbraun
Copy link
Member

vbraun commented Dec 25, 2016

Fails with

gfortran -m128bit-long-double -Wall -m64  -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib  -o dblat2 dblat2.o ../libopenblas_sandybridgep-r0.2.19.a -lpthread -lgfortran -lpthread -lgfortran 
ld: file too small (length=0) file '../libopenblas_sandybridgep-r0.2.19.a' for architecture x86_64
collect2: error: ld returned 1 exit status
gfortran -m128bit-long-double -Wall -m64  -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib  -o cblat2 cblat2.o ../libopenblas_sandybridgep-r0.2.19.a -lpthread -lgfortran -lpthread -lgfortran 
make[4]: *** [sblat1] Error 1

Depends on #22021

CC: @kiwifb

Component: linear algebra

Author: François Bissey

Branch/Commit: ea0c0f7

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/22100

@vbraun vbraun added this to the sage-7.5 milestone Dec 25, 2016
@vbraun
Copy link
Member Author

vbraun commented Dec 25, 2016

comment:1

More log

Successfully installed openblas-0.2.19.p0
Running the test suite for openblas-0.2.19.p0...
touch libopenblas_sandybridgep-r0.2.19.a
make -j 8 -C test all
make[4]: warning: -jN forced in submake: disabling jobserver mode.
gfortran -m128bit-long-double -Wall -m64  -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib  -o sblat1 sblat1.o ../libopenblas_sandybridgep-r0.2.19.a -lpthread -lgfortran -lpthread -lgfortran 
gfortran -m128bit-long-double -Wall -m64  -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib  -o dblat1 dblat1.o ../libopenblas_sandybridgep-r0.2.19.a -lpthread -lgfortran -lpthread -lgfortran 
gfortran -m128bit-long-double -Wall -m64  -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib  -o cblat1 cblat1.o ../libopenblas_sandybridgep-r0.2.19.a -lpthread -lgfortran -lpthread -lgfortran 
gfortran -m128bit-long-double -Wall -m64  -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib  -o zblat1 zblat1.o ../libopenblas_sandybridgep-r0.2.19.a -lpthread -lgfortran -lpthread -lgfortran 
gfortran -m128bit-long-double -Wall -m64  -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib  -o sblat2 sblat2.o ../libopenblas_sandybridgep-r0.2.19.a -lpthread -lgfortran -lpthread -lgfortran 
gfortran -m128bit-long-double -Wall -m64  -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib  -o dblat2 dblat2.o ../libopenblas_sandybridgep-r0.2.19.a -lpthread -lgfortran -lpthread -lgfortran 
ld: file too small (length=0) file '../libopenblas_sandybridgep-r0.2.19.a' for architecture x86_64
collect2: error: ld returned 1 exit status
gfortran -m128bit-long-double -Wall -m64  -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib  -o cblat2 cblat2.o ../libopenblas_sandybridgep-r0.2.19.a -lpthread -lgfortran -lpthread -lgfortran 
make[4]: *** [sblat1] Error 1
ld: file too small (length=0) file '../libopenblas_sandybridgep-r0.2.19.a' for gfortran -m128bit-long-double -Wall -m64  -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib  -o zblat2 zblat2.o ../libopenblas_sandybridgep-r0.2.19.a -lpthread -lgfortran -lpthread -lgfortran 
architecture x86_64
collect2: error: ld returned 1 exit status
make[4]: *** [dblat1] Error 1
gfortran -m128bit-long-double -Wall -m64  -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib  -o sblat3 sblat3.o ../libopenblas_sandybridgep-r0.2.19.a -lpthread -lgfortran -lpthread -lgfortran 
ld: file too small (length=0) file '../libopenblas_sandybridgep-r0.2.19.a' for architecture x86_64
collect2: error: ld returned 1 exit status
make[4]: *** [cblat1] Error 1
gfortran -m128bit-long-double -Wall -m64  -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib  -o dblat3 dblat3.o ../libopenblas_sandybridgep-r0.2.19.a -lpthread -lgfortran -lpthread -lgfortran 
ld: file too small (length=0) file '../libopenblas_sandybridgep-r0.2.19.a' for architecture x86_64
collect2: error: ld returned 1 exit status
make[4]: *** [zblat1] Error 1
gfortran -m128bit-long-double -Wall -m64  -L/Users/buildslave-sage/slave/sage_git/build/local/lib -Wl,-rpath,/Users/buildslave-sage/slave/sage_git/build/local/lib  -o cblat3 cblat3.o ../libopenblas_sandybridgep-r0.2.19.a -lpthread -lgfortran -lpthread -lgfortran 
ld: file too small (length=0) file '../libopenblas_sandybridgep-r0.2.19.a' for architecture x86_64
collect2: error: ld returned 1 exit status
make[4]: *** [sblat2] Error 1

@kiwifb
Copy link
Member

kiwifb commented Dec 25, 2016

comment:2

OK, so spkg-install ran ok but no spkg-check is failing. For exactly the same reason and I should say at exactly the same point. This is because we already run the test suite of openblas in spkg-install as it seems to be part of the default target. And we have a failure in spkg-check because make was not run with the same arguments as in spkg-install - notably USE_THREAD=0. There are three things we could do at this stage:

  • fix spkg-install so the test suite is not run and make sure spkg-check is run with same options. Because there is no configuration as such the settings are not preserved from one run to another.
  • remove spkg-check and make a note that the test suite is run during spkg-install. By far the easiest solution.
  • status quo, fix spkg-check to use the same options as spkg-install and keep running the test suite in both spkg-install and spkg-check.

Other notes: this output means that the last patch I didn't forward upstream is what is needed to fix the build in #22021. A problem with ifdef, I cannot really forward that patch upstream without knowing precisely what shell was making it fail. I also would have to make the fix comprehensive over other makefile and possibly other use of ifdef.

@vbraun
Copy link
Member Author

vbraun commented Dec 25, 2016

comment:3

FWIW I'm using the default shell on OSX, i.e. an ancient bash (version 3.2.57)

@kiwifb
Copy link
Member

kiwifb commented Dec 25, 2016

comment:4

Replying to @vbraun:

FWIW I'm using the default shell on OSX, i.e. an ancient bash (version 3.2.57)

OK when I make a PR upstream, I can say something about the environment. In the mean time, out of the three options, what do you favor?

@vbraun
Copy link
Member Author

vbraun commented Dec 25, 2016

comment:5

Is there an easy way to not run the testsuite in spkg-install? then that would be nice to minimise install time. If not then I'd just remove spkg-check since its redundant...

@kiwifb
Copy link
Member

kiwifb commented Dec 25, 2016

comment:6

Replying to @vbraun:

Is there an easy way to not run the testsuite in spkg-install? then that would be nice to minimise install time. If not then I'd just remove spkg-check since its redundant...

The main makefile has

all :: libs netlib tests shared

so I am guessing we could call make on libs netlib shared. I'll put something together to try.

@kiwifb
Copy link
Member

kiwifb commented Dec 25, 2016

Commit: ea0c0f7

@kiwifb
Copy link
Member

kiwifb commented Dec 25, 2016

Dependencies: #22021

@kiwifb
Copy link
Member

kiwifb commented Dec 25, 2016

Author: François Bissey

@kiwifb
Copy link
Member

kiwifb commented Dec 25, 2016

comment:7

OK there it is. It obviously depends on #22021.


New commits:

27f412bDisable multi-threading in OpenBLAS
0266727Fix a few QA in Openblas
ea0c0f7run tests only in spkg-check. Also run spkg-check with the same options as spkg-install

@kiwifb
Copy link
Member

kiwifb commented Dec 25, 2016

Branch: u/fbissey/openblas_tests

@vbraun
Copy link
Member Author

vbraun commented Dec 25, 2016

Reviewer: Volker Braun

@vbraun
Copy link
Member Author

vbraun commented Dec 25, 2016

comment:8

Thanks, lgtm!

@vbraun
Copy link
Member Author

vbraun commented Dec 26, 2016

Changed branch from u/fbissey/openblas_tests to ea0c0f7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants