Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change type to ... in src/doc #22114

Closed
fchapoton opened this issue Dec 31, 2016 · 8 comments
Closed

change type to ... in src/doc #22114

fchapoton opened this issue Dec 31, 2016 · 8 comments
Labels
c: python3 p: major / 3 t: enhancement
Milestone
sage-7.6

Comments

@fchapoton
Copy link
Contributor

part of #16085

needed for the tests to pass with Py3

CC: @tscrim @jm58660 @a-andre

Component: python3

Author: Frédéric Chapoton

Branch/Commit: 773945c

Reviewer: Jori Mäntysalo

Issue created by migration from https://trac.sagemath.org/ticket/22114
@fchapoton fchapoton added this to the sage-7.5 milestone Dec 31, 2016
@fchapoton
Copy link
Contributor Author

Commit: 773945c

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/22114

@fchapoton
Copy link
Contributor Author

New commits:

aef20f0type list > ... list
f816c1btype str > ... str
9331d81type tuple > ... tuple
4745b17type function > ... function
773945ctype int,dict,float > ... int,dict,float

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Jan 2, 2017

Reviewer: Jori Mäntysalo

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Jan 2, 2017

comment:2

I'll take.

@jm58660
Copy link
Mannequin

jm58660 mannequin commented Jan 2, 2017

comment:3

OK. Were these done with

find ... | xargs perl -e "s|(^ +<)type ('[^']+'>$)|\1... \2|g;" -p -i.bak

?

rc1 is out, so I changed the milestone.

@jm58660 jm58660 mannequin modified the milestones: sage-7.5, sage-7.6 Jan 2, 2017
@fchapoton
Copy link
Contributor Author

comment:4

This was done with several grep and replace, indeed, but I left out the case of "<type 'instancemethod'>" because I do not know the behavior of that in Py3.

@vbraun
Copy link
Member

vbraun commented Jan 21, 2017

Changed branch from u/chapoton/22114 to 773945c

@vbraun vbraun closed this as completed in 5a4d646 Jan 21, 2017
@wluebbe wluebbe mannequin mentioned this issue Feb 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.6
Development

No branches or pull requests
2 participants
@vbraun @fchapoton