Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set embedding of extension in QQ[2^(1/3)] #22150

Open
videlec opened this issue Jan 7, 2017 · 13 comments
Open

Set embedding of extension in QQ[2^(1/3)] #22150

videlec opened this issue Jan 7, 2017 · 13 comments

Comments

@videlec
Copy link
Contributor

videlec commented Jan 7, 2017

Before

sage: QQ[2^(1/3)].coerce_embedding()
Generic morphism:
  From: Number Field in a with defining polynomial x^3 - 2
  To:   Real Lazy Field
  Defn: a -> 1.259921049894873?

After

sage: QQ[2^(1/3)].coerce_embedding()
Generic morphism:
  From: Number Field in a with defining polynomial x^3 - 2
  To:   Algebraic Real Field
  Defn: a -> 1.259921049894873?

Component: number fields

Work Issues: see patchbot report

Author: Vincent Delecroix

Branch/Commit: u/vdelecroix/22150 @ 3360768

Issue created by migration from https://trac.sagemath.org/ticket/22150

@videlec videlec added this to the sage-7.5 milestone Jan 7, 2017
@videlec
Copy link
Contributor Author

videlec commented Jan 7, 2017

Branch: u/vdelecroix/22150

@videlec
Copy link
Contributor Author

videlec commented Jan 7, 2017

Commit: 3360768

@videlec
Copy link
Contributor Author

videlec commented Jan 7, 2017

New commits:

336076822150 set embedding appropriately in QQ[2^(1/3)]

@mezzarobba
Copy link
Member

Work Issues: see patchbot report

@fchapoton
Copy link
Contributor

comment:3

Needs rebase.

Moreover, there is a problem coming from

sage: sqrt(-3).is_real()
True

@mezzarobba
Copy link
Member

comment:4

Whoops, I had forgotten about this ticket, but see #23117.

@fchapoton
Copy link
Contributor

comment:5

so we can close this as duplicate, right ?

@fchapoton fchapoton removed this from the sage-7.5 milestone Jun 22, 2017
@fchapoton
Copy link
Contributor

comment:6

Hmm. currently we get:

Generic morphism:
  From: Number Field in a with defining polynomial x^3 - 2
  To:   Real Lazy Field
  Defn: a -> 1.259921049894873?

with target the real lazy field instead of AA.

@videlec
Copy link
Contributor Author

videlec commented Jun 22, 2017

comment:7

It would have been better if you just have read the ticket description.

@videlec videlec added this to the sage-8.0 milestone Jun 22, 2017
@fchapoton
Copy link
Contributor

comment:8

What do you mean ? The ticket description is no longer valid...

@videlec

This comment has been minimized.

@videlec
Copy link
Contributor Author

videlec commented Jun 22, 2017

comment:9

The branch is not either. I think that #23117 was actually a bad idea. Coercion should not go through the real lazy field.

@mezzarobba
Copy link
Member

comment:10

Replying to @videlec:

The branch is not either. I think that #23117 was actually a bad idea. Coercion should not go through the real lazy field.

I agree that complex embeddings should go to QQbar or something like that by default, but for me this is a separate issue, already tracked elsewhere.

However, having the K[α] syntax create the “standard” embedding makes more sense to me (less confusing, probably breaks fewer existing things) than having it attempt to embed the number field in α's parent or something like that—if that's what you have in mind.

@mkoeppe mkoeppe removed this from the sage-8.0 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants