Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom log function for asymptotic rings #22154

Closed
dkrenn opened this issue Jan 8, 2017 · 25 comments
Closed

allow custom log function for asymptotic rings #22154

dkrenn opened this issue Jan 8, 2017 · 25 comments

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Jan 8, 2017

To avoid slipping into the symbolic ring, extend the existing log method of the asymptotic ring to allow a parameter log_function which is used instead of SageMath's log.

Depends on #26498

CC: @behackl @cheuberg

Component: asymptotic expansions

Author: Daniel Krenn

Branch/Commit: c69f21f

Reviewer: Benjamin Hackl

Issue created by migration from https://trac.sagemath.org/ticket/22154

@dkrenn dkrenn added this to the sage-7.5 milestone Jan 8, 2017
@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 8, 2017

Branch: u/dkrenn/asy-log-function

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2018

Commit: 42b68d5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 17, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

46549aaMerge tag '8.4.beta5' into t/22154/asy-log-function
42b68d5fix typo in doc

@dkrenn
Copy link
Contributor Author

dkrenn commented Oct 18, 2018

Dependencies: #26498

@dkrenn
Copy link
Contributor Author

dkrenn commented Oct 18, 2018

comment:3

Depends on #26498 as both change the classcall/init of the asymptotic ring

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2018

Changed commit from 42b68d5 to 33117ae

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2018

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

c46c6a6customize (Exact|O)TermMonoid in factory
0bf6db6fix pickling
17e3a98update doctests due to insights in pickling
47cd6fcfixup doctests (name of factory)
73b4bcfnew convenience method term_monoid
0e45ca8Trac #26498: convenience method term_monoid
2e9317eTrac #26498: take care of term_monoid_factory in Functors
0d8c5f2Merge branch 't/26498/asy-own-term-monoid-factory' into t/22154/asy-log-function
f3fadc3Trac #22154: introduce asymptotic ring global log_function
33117aeTrac #22154: update one doctest due to recent changes in log

@dkrenn

This comment has been minimized.

@dkrenn
Copy link
Contributor Author

dkrenn commented Oct 18, 2018

comment:5

At some point the same should be done for rpow and exp, but not here.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

ec74ad0Trac #22154: rename log_function to log
20e2435Trac #22154: update doc/doctests of doc-method of parent

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 18, 2018

Changed commit from 33117ae to 20e2435

@dkrenn
Copy link
Contributor Author

dkrenn commented Oct 18, 2018

Changed work issues from rpow, exp to none

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 20, 2018

Changed commit from 20e2435 to 39545cc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 20, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

40708fdTrac #26498: fixup `__init__` (somehow a line was not commited)
39545ccMerge branch 't/26498/asy-own-term-monoid-factory' into t/22154/asy-log-function

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 7, 2018

Changed commit from 39545cc to 49f0d28

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 7, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

49f0d28Trac #22154 (py3): insert parenthesis in except

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 12, 2018

Changed commit from 49f0d28 to 931f9da

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 12, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

432dca4Trac #26498: method term_monoid
931f9daMerge branch 't/26498/asy-own-term-monoid-factory' into t/22154/asy-log-function

@behackl
Copy link
Member

behackl commented Apr 17, 2019

Reviewer: Benjamin Hackl

@behackl
Copy link
Member

behackl commented Apr 17, 2019

comment:11

This extension to support custom log-functions looks good to me.

The keyword log should also be documented in the docstring of the AsymptoticRing (asymptotic_ring.py, L3322), please add a short explanation.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 17, 2019

Changed commit from 931f9da to c69f21f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 17, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

c69f21fTrac #22154: document log in AsymptoticRing

@dkrenn
Copy link
Contributor Author

dkrenn commented Apr 17, 2019

comment:13

Replying to @behackl:

This extension to support custom log-functions looks good to me.

The keyword log should also be documented in the docstring of the AsymptoticRing (asymptotic_ring.py, L3322), please add a short explanation.

Done in

c69f21f Trac #22154: document log in AsymptoticRing

@behackl
Copy link
Member

behackl commented Apr 17, 2019

comment:15

Thank you, LGTM.

@vbraun
Copy link
Member

vbraun commented Apr 27, 2019

Changed branch from u/dkrenn/asy-log-function to c69f21f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants