Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

giac has undeclared dependency on libpng #22163

Closed
jdemeyer opened this issue Jan 10, 2017 · 14 comments
Closed

giac has undeclared dependency on libpng #22163

jdemeyer opened this issue Jan 10, 2017 · 14 comments

Comments

@jdemeyer
Copy link

CC: @frederichan-IMJPRG

Component: packages: standard

Keywords: atelierpari2017

Author: Jeroen Demeyer

Branch: 015a7d8

Reviewer: Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/22163

@jdemeyer
Copy link
Author

@jdemeyer
Copy link
Author

New commits:

015a7d8giac depends on libpng

@jdemeyer
Copy link
Author

Commit: 015a7d8

@jpflori
Copy link

jpflori commented Jan 10, 2017

Reviewer: Jean-Pierre Flori

@jpflori
Copy link

jpflori commented Jan 10, 2017

comment:4

Does GIAC use -lpng1x rather than -lpng?
Or should we patch?

@frederichan-IMJPRG
Copy link

comment:5

during the spkg built my Makefile have this:

LIBS = -lrt -lpthread -ldl -lpng -lm -lmpfi -lmpfr -lgmp 
LIBTERMCAP = -ltermcap

@jdemeyer
Copy link
Author

comment:6

We probably should patch. But that's not an issue for this ticket.

@jpflori
Copy link

jpflori commented Jan 10, 2017

comment:7

Ok so let's already merge this.

@jdemeyer
Copy link
Author

Changed keywords from none to atelierpari2017

@jpflori
Copy link

jpflori commented Jan 12, 2017

comment:9

FYI, on OS X, configure finds the system libpng, looks for a main symbol in it which is not existent there, and just compiles without png support.

@frederichan-IMJPRG
Copy link

comment:10

Replying to @jpflori:

FYI, on OS X, configure finds the system libpng, looks for a main symbol in it which is not existent there, and just compiles without png support.

Up to now I think that it is not a problem to don't have png in giac from sage. giacpy or pynac are not using it.

@vbraun
Copy link
Member

vbraun commented Jan 18, 2017

Changed branch from u/jdemeyer/giac_has_undeclared_dependency_on_libpng to 015a7d8

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Mar 10, 2017

Changed commit from 015a7d8 to none

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Mar 10, 2017

comment:12

Replying to @frederichan-IMJPRG:

Up to now I think that it is not a problem to don't have png in giac from sage. giacpy or pynac are not using it.

For what it worth, for Sage Debian Live, i compile giac (from within Sage) with xcas support, by installing the system's fltk, remove the --disable flag and the nofltk-check.patch, so i guess for such a graphical use, png support could be useful.

What would be a correct patch (so that i can add it to SDL until it get fixed) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants