Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounded affine permutation of a matrix #22187

Closed
sagetrac-rkarpman mannequin opened this issue Jan 13, 2017 · 22 comments
Closed

Bounded affine permutation of a matrix #22187

sagetrac-rkarpman mannequin opened this issue Jan 13, 2017 · 22 comments

Comments

@sagetrac-rkarpman
Copy link
Mannequin

sagetrac-rkarpman mannequin commented Jan 13, 2017

Added a method bounded_affine_permutation to permutation, which outputs a partial permutation representing the bounded affine permutation of a real matrix.

CC: @egunawan @VivianePons @jessicapalencia

Component: combinatorics

Keywords: days82, bounded affine permutation, decorated permutation, positroid

Author: Rachel Karpman

Branch/Commit: 8862fa1

Reviewer: Travis Scrimshaw, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/22187

@sagetrac-rkarpman sagetrac-rkarpman mannequin added this to the sage-7.6 milestone Jan 13, 2017
@sagetrac-rkarpman
Copy link
Mannequin Author

sagetrac-rkarpman mannequin commented Jan 13, 2017

Commit: 5ff1792

@sagetrac-rkarpman
Copy link
Mannequin Author

sagetrac-rkarpman mannequin commented Jan 13, 2017

Branch: u/rkarpman/22187bdd_affine

@sagetrac-rkarpman
Copy link
Mannequin Author

sagetrac-rkarpman mannequin commented Jan 13, 2017

New commits:

5ff1792inital commit for adding bdd_affine_perm method in permutation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

80381a4Added citation for KLS2013 to index, updated reference in permutation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2017

Changed commit from 5ff1792 to 80381a4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

dd59939"fixed white space in documentation"

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 13, 2017

Changed commit from 80381a4 to dd59939

@tscrim

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Jan 13, 2017

comment:4

Some comments:

  • You should spell out the method names in full bounded_affine_permutation.
  • The INPUT: block should be - ``A`` -- a matrix with complex entries`.
  • You should move the OUTPUT: block to be right after the 1-line description and use latex formatting with single backticks, e.g., `i` with appropriate modifications to matrix it into a definition-type statement.
  • The OUTPUT: block should be something like A partial permutation of length `n` of `[2n]` , where `n` is ``A.ncols()``.
  • Remove the line For more on bounded affine permutations, see.
  • You can use the more simple (and Python3 compatible) S = Permutations(2*n, n).
  • You should use the base ring/field of A as the user might want more precision or use a particular subset of C.

@tscrim

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented May 21, 2017

@tscrim
Copy link
Collaborator

tscrim commented May 21, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented May 21, 2017

Changed commit from dd59939 to fafc898

@tscrim
Copy link
Collaborator

tscrim commented May 21, 2017

comment:5

I've implemented the changes I suggested in comment:4. Just needs someone else to take a look.


New commits:

095760eMerge branch 'u/rkarpman/22187bdd_affine' of git://trac.sagemath.org/sage into public/combinat/bounded_affine_permutation-22187
fafc898Some reviewer changes.

@tscrim tscrim modified the milestones: sage-7.6, sage-8.0 May 21, 2017
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 21, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6b8ada7Some reviewer changes.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 21, 2017

Changed commit from fafc898 to 6b8ada7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 29, 2017

Changed commit from 6b8ada7 to 8862fa1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 29, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

c2d250aMerge branch 'public/combinat/bounded_affine_permutation-22187' in 8.0.b8
8862fa1trac 22187 details (pep8)

@fchapoton
Copy link
Contributor

comment:8

ok, looks good to me. Travis, please double check my small changes.

@tscrim
Copy link
Collaborator

tscrim commented May 29, 2017

comment:9

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented May 29, 2017

Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented May 31, 2017

Changed branch from public/combinat/bounded_affine_permutation-22187 to 8862fa1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants