Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Sage's documentation style, in particular use ".. FOO::" rather than ".. foo::" #22188

Closed
jhpalmieri opened this issue Jan 13, 2017 · 15 comments

Comments

@jhpalmieri
Copy link
Member

The preferred style in Sage documentation is for Sphinx directives to be in upper case: .. NOTE:: rather than .. note::, for example. We should document this.

CC: @tscrim

Component: documentation

Author: John Palmieri

Branch/Commit: 7da959b

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/22188

@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/NOTE

@jhpalmieri
Copy link
Member Author

Commit: fb1dd0c

@jhpalmieri
Copy link
Member Author

comment:2

This may conflict with #22178. That's easy enough to fix once we're sure #22178 has stabilized.


New commits:

fb1dd0cTrac 22188: Document Sage's documentation style.

@tscrim
Copy link
Collaborator

tscrim commented Jan 13, 2017

comment:4

I doubt #22178 will change any more, but it will be a trivial fix if git doesn't automatically handle the merge.

@tscrim
Copy link
Collaborator

tscrim commented Jan 13, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Jan 28, 2017

comment:5

PDF docs don't build:

[docpdf] ! You can't use `macro parameter character #' in math mode.
[docpdf] l.3552 <http://www.sphinx-doc.org/rest.html#
[docpdf]                                             citations>_. For links to trac t...

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 28, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

7cfee55trac 22188: add missing `

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 28, 2017

Changed commit from fb1dd0c to 7cfee55

@jhpalmieri
Copy link
Member Author

comment:7

Oops, there was a missing backquote. Should be fixed now.

@kiwifb
Copy link
Member

kiwifb commented Jan 30, 2017

comment:9

Hum, not building html for me on sage-on-gentoo

Error building the documentation.
Traceback (most recent call last):
  File "sage_setup/docbuild/__main__.py", line 2, in <module>
    main()
  File "/scratch2/portage/sci-mathematics/sage-9999/work/sage-9999/src-python2_7/sage_setup/docbuild/__init__.py", line 1667, in main
    builder()
  File "/scratch2/portage/sci-mathematics/sage-9999/work/sage-9999/src-python2_7/sage_setup/docbuild/__init__.py", line 324, in _wrapper
    build_many(build_other_doc, L)
  File "/scratch2/portage/sci-mathematics/sage-9999/work/sage-9999/src-python2_7/sage_setup/docbuild/__init__.py", line 252, in build_many
    ret = x.get(99999)
  File "/usr/lib64/python2.7/multiprocessing/pool.py", line 567, in get
    raise self._value
OSError: [developer] /scratch2/portage/sci-mathematics/sage-9999/work/sage-9999/src-python2_7/doc/en/developer/coding_basics.rst:5: WARNING: Duplicate explicit target name: "sphinx/rest markup for citations".

@kiwifb
Copy link
Member

kiwifb commented Jan 30, 2017

comment:11

See http://stackoverflow.com/questions/5464627/how-to-have-same-text-in-two-links-with-restructured-text

Apparently you need two underscores instead of one in

<http://www.sphinx-doc.org/rest.html#citations>`_

I am guessing in both occurrence of that particular string.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2017

Changed commit from 7cfee55 to 7da959b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

7da959btrac 22188: fix duplicate reference, reST capitalization

@jhpalmieri
Copy link
Member Author

comment:13

Both citations should point to the same place, so I've changed their targets instead.

@vbraun
Copy link
Member

vbraun commented Jan 31, 2017

Changed branch from u/jhpalmieri/NOTE to 7da959b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants